Uh oh!
There was an error while loading. Please reload this page.
feat: Add missing notification_setting to Team - #3431
Merged
gmlewis merged 2 commits intoJan 14, 2025
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
1 task
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
commented
Jan 14, 2025
ContributorAuthor
I've fixed the failing tests, the |
gmlewis
approved these changes
Jan 14, 2025
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @stevehipwell !
LGTM.
Merging after tests pass.
TeamCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3431 +/- ##
==========================================
- Coverage 97.72% 92.26% -5.46%
==========================================
Files 153 174 +21 Lines 13390 15023 +1633 ==========================================
+ Hits 13085 13861 +776 - Misses 215 1068 +853 - Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
notification_settingfield from theTeamtype (it was already present inNewTeam).