Skip to content

fix(ci): ensure 'auto' toolchain applies to generate - #3436

Merged
gmlewis merged 3 commits into
google:masterfrom
dnwe:fix-generate
Mar 10, 2025
Merged

fix(ci): ensure 'auto' toolchain applies to generate#3436
gmlewis merged 3 commits into
google:masterfrom
dnwe:fix-generate

Conversation

@dnwe

@dnwednwe commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Comment threadscript/generate.sh Outdated
@gmlewis

Copy link
Copy Markdown
Collaborator

@dnwe - I would also personally appreciate it if you stopped using force-push in this repo, because this is not the same as what I originally reviewed, and it helps me to see the progression. Thank you!

@dnwe

dnwe commented Jan 16, 2025

Copy link
Copy Markdown
ContributorAuthor

@dnwe - I would also personally appreciate it if you stopped using force-push in this repo, because this is not the same as what I originally reviewed, and it helps me to see the progression. Thank you!

Apart from the first time (where I corrected a mistake pre-review) that was just me hitting rebase in the UI because my branch was out-of-date with master. The UI does show each of the commit refs for each rebase

@codecov

codecovBot commented Jan 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.21%. Comparing base (2b8c7fa) to head (2b83750).
Report is 274 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3436 +/- ##
==========================================
- Coverage 97.72% 91.21% -6.51% 
==========================================
Files 153 182 +29 Lines 13390 15930 +2540 ==========================================
+ Hits 13085 14531 +1446 - Misses 215 1225 +1010 - Partials 90 174 +84 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Applying suggestion
Comment threadscript/generate.sh Outdated
Applying suggestion

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually applied suggestions.
LGTM.
Merging.

@gmlewis
gmlewis merged commit 76d1d46 into google:masterMar 10, 2025
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dnwe@gmlewis@stevehipwell