Skip to content

gen-accessors: update dumping of getters - #3437

Merged
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:update-gen-accessors-dump
Jan 16, 2025
Merged

gen-accessors: update dumping of getters#3437
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:update-gen-accessors-dump

Conversation

@alexandear

@alexandearalexandear commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

After merging this PR, the checks for #3433 will become green (I checked here).

The PR addresses the issue described in #3433 (comment): we need to guarantee the order of equal getters.

func (s*SMTP) GetUsername() string {
ifs==nil||s.Username==nil {
return""
}
return*s.Username
}
// GetUserName returns the UserName field if it's non-nil, zero value otherwise.func (s*SMTP) GetUserName() string {
ifs==nil||s.UserName==nil {
return""
}
return*s.UserName
}

@codecov

codecovBot commented Jan 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (2b8c7fa) to head (ec4431e).
Report is 223 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3437 +/- ##
==========================================
- Coverage 97.72% 92.26% -5.46% 
==========================================
Files 153 174 +21 Lines 13390 15023 +1633 ==========================================
+ Hits 13085 13861 +776 - Misses 215 1068 +853 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.
Merging.

@gmlewis
gmlewis merged commit d13c739 into google:masterJan 16, 2025
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandear@gmlewis