Skip to content

chore: Fix codecov upload - #3440

Merged
gmlewis merged 1 commit into
google:masterfrom
stevehipwell:fix-codecov
Jan 20, 2025
Merged

chore: Fix codecov upload#3440
gmlewis merged 1 commit into
google:masterfrom
stevehipwell:fix-codecov

Conversation

@stevehipwell

@stevehipwellstevehipwell commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

This PR updates the Codecov action to use native GH OIDC support to authenticate pushing coverage from the master branch.

Fixes: #3439.
Closes: #3221.

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell !
LGTM.
Merging.

@gmlewis
gmlewis merged commit ce3a839 into google:masterJan 20, 2025
@codecov

codecovBot commented Jan 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (2b8c7fa) to head (e0bfae6).
Report is 224 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3440 +/- ##
==========================================
- Coverage 97.72% 92.26% -5.46% 
==========================================
Files 153 174 +21 Lines 13390 15023 +1633 ==========================================
+ Hits 13085 13861 +776 - Misses 215 1068 +853 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehipwell
stevehipwell deleted the fix-codecov branch January 20, 2025 14:51
@gmlewis

Copy link
Copy Markdown
Collaborator

I wonder why it still says this?

Report is 224 commits behind head on master.

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codecov action failing to upload for master due to a missing token

2 participants

@stevehipwell@gmlewis