Skip to content

fix!: Typo in field names in the CheckSuite struct - #3444

Merged
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:fix/typo-checksuite-fields
Jan 20, 2025
Merged

fix!: Typo in field names in the CheckSuite struct#3444
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:fix/typo-checksuite-fields

Conversation

@alexandear

@alexandearalexandear commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: Rerequstable=>Rerequestable, RunsRerequstable=>RunsRerequestable

Fixes: #3443.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Jan 20, 2025
@alexandear
alexandearforce-pushed the fix/typo-checksuite-fields branch from 5eb0ba3 to 0388ebeCompareJanuary 20, 2025 17:59
@codecov

codecovBot commented Jan 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (eb92cca) to head (0388ebe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3444 +/- ##
=======================================
Coverage 92.26% 92.26% =======================================
Files 174 174 Lines 15023 15023 =======================================
Hits 13861 13861 Misses 1068 1068 Partials 94 94 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexandear

Copy link
Copy Markdown
ContributorAuthor

@gmlewis, maybe it makes sense to configure "Approval for running fork pull request workflows from contributors", so that workflows run automatically for all users who have contributed to the repo.

image

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis, maybe it makes sense to configure "Approval for running fork pull request workflows from contributors", so that workflows run automatically for all users who have contributed to the repo.

Yes, thank you, @alexandear, but unfortunately, as a Xoogler, I no longer have access to that link.
This is how I have set my other repos that I do control, but can no longer control the settings for this repo.
Also, unfortunately, I do not seem to get responses any more from the team that does. 😞

As a result, I attempt to be responsive when changes are made to PRs and check for malware before clicking "Approve".
Triple unfortunately, this last year I've seen the most attacks on this repo with malware than any of the other prior many years I've been maintaining this repo... so I must be careful with commits.

I understand that it is frustrating to push a commit and then watch and wait for the CI/CD tooling to run, and I apologize.
I will continue to try and be responsive and I greatly appreciate your patience. Thank you!

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - do you have time for a code review?

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @stevehipwell!
Merging.

@gmlewisgmlewis changed the title fix: Typo in field names in the CheckSuite structfix!: Typo in field names in the CheckSuite structJan 20, 2025
@gmlewis
gmlewis merged commit c44e9dd into google:masterJan 20, 2025
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 20, 2025
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
BREAKING CHANGE: `Rerequstable`=>`Rerequestable`, `RunsRerequstable`=>`RunsRerequestable`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in field names in the CheckSuite struct

3 participants

@alexandear@gmlewis@stevehipwell