Skip to content

chore!: Add sliceofpointers custom linter - #3447

Merged
gmlewis merged 10 commits into
google:masterfrom
gmlewis:add-no-pointer-to-string-slice
Jan 22, 2025
Merged

chore!: Add sliceofpointers custom linter #3447
gmlewis merged 10 commits into
google:masterfrom
gmlewis:add-no-pointer-to-string-slice

Conversation

@gmlewis

@gmlewisgmlewis commented Jan 21, 2025

Copy link
Copy Markdown
Collaborator

BREAKING CHANGE: ListOAuthApps now returns ([]*OAuthApp, error) instead of ([]OAuthApp, error).

This PR should help developers use a consistent style by not writing []*string or []T in their PRs.
It should also ease the maintenance burden by not having to repeat this over and over again.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
…inter
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
gmlewis marked this pull request as draft January 21, 2025 19:55
@codecov

codecovBot commented Jan 21, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (27bd175) to head (15174df).
Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3447 +/- ##
=======================================
Coverage 91.03% 91.03% =======================================
Files 179 179 Lines 15532 15532 =======================================
Hits 14139 14139 Misses 1221 1221 Partials 172 172 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Comment thread.custom-gcl.yml Outdated
gmlewisand others added 2 commits January 21, 2025 16:19
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
gmlewis marked this pull request as ready for review January 22, 2025 01:06
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 22, 2025
@gmlewisgmlewis changed the title Add sliceofpointers custom linter chore!: Add sliceofpointers custom linter Jan 22, 2025
@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jan 22, 2025
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewisgmlewis changed the title chore!: Add sliceofpointers custom linter chore!: Add sliceofpointers custom linter Jan 22, 2025
@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

@stevehipwell - do you have time for a code review? Thank you!

@ldez

ldez commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

I'm curious: what is the reasoning behind using slice of pointer of struct inside of slice of struct?

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 22, 2025
@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @ldez!
Merging.

@gmlewis
gmlewis merged commit 07b0446 into google:masterJan 22, 2025
@gmlewis
gmlewis deleted the add-no-pointer-to-string-slice branch January 22, 2025 02:34
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
BREAKING CHANGE: `ListOAuthApps` now returns `([]*OAuthApp, error)` instead of `([]OAuthApp, error)`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gmlewis@ldez