Skip to content

feat: Add JSON marshal tests for dependabot alerts - #3480

Merged
gmlewis merged 2 commits into
google:masterfrom
raisa2010:feat/add-dependabot-alert-tests
Feb 15, 2025
Merged

feat: Add JSON marshal tests for dependabot alerts#3480
gmlewis merged 2 commits into
google:masterfrom
raisa2010:feat/add-dependabot-alert-tests

Conversation

@raisa2010

@raisa2010raisa2010 commented Feb 15, 2025

Copy link
Copy Markdown
Contributor

This PR adds some more tests for issue #55. Would appreciate a review!

Also noticed that some fields in the Github API response such as cvss_severities and epss are not supported in the existing struct. Is this expected (deprecated fields) or just new fields in the Github response that haven't been reflected in the current codebase yet?

Thanks in advance!

@raisa2010
raisa2010force-pushed the feat/add-dependabot-alert-tests branch from d41dbb8 to db419faCompareFebruary 15, 2025 12:13
@codecov

codecovBot commented Feb 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (6c46d71) to head (d8eebc1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3480 +/- ##
=======================================
Coverage 91.02% 91.02% =======================================
Files 179 179 Lines 15561 15561 =======================================
Hits 14165 14165 Misses 1223 1223 Partials 173 173 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis

Copy link
Copy Markdown
Collaborator

Also noticed that some fields in the Github API response such as cvss_severities and epss are not supported in the existing struct. Is this expected (deprecated fields) or just new fields in the Github response that haven't been reflected in the current codebase yet?

There are several possibilities, and I would have to look up those specific cases to answer your question but don't have time at the moment. We rarely remove fields but do try to mark them as deprecated if indeed they are. Most of the time, they are added by GitHub after our endpoints are written. When someone needs them, we add a PR.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @raisa2010.
LGTM.
Merging.

@gmlewis
gmlewis merged commit 81dc7a9 into google:masterFeb 15, 2025
@raisa2010

Copy link
Copy Markdown
ContributorAuthor

Got it, thank you for clarifying and reviewing @gmlewis!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@raisa2010@gmlewis