Skip to content

docs: Update readme and examples for updated go-github-ratelimit and introduce go-github-pagination - #3504

Merged
gmlewis merged 7 commits into
google:masterfrom
gofri:master
Mar 14, 2025
Merged

docs: Update readme and examples for updated go-github-ratelimit and introduce go-github-pagination#3504
gmlewis merged 7 commits into
google:masterfrom
gofri:master

Conversation

@gofri

@gofrigofri commented Mar 9, 2025

Copy link
Copy Markdown
Contributor

Closes: #2618.

Hey,

Opened this PR following the v2 release of go-github-ratelimit (🥳) that supports primary rate limits handling,
as well as the releaes of go-github-pagination as mentioned in #2618.

This PR only touches the main README file and the examples.

@gmlewisgmlewis changed the title docs: update readme and examples for updated go-github-ratelimit and introduce go-github-paginationdocs: Update readme and examples for updated go-github-ratelimit and introduce go-github-paginationMar 9, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gofri!

Comment threadexample/go.mod Outdated
Comment on lines +3 to +5
go 1.23.1

toolchain go1.23.5

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will have to wait until be bump the Go toolchain for the entire repo.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, please delete lines 4 and 5 and merge in the latest changes from the master branch which should make line 3 say go 1.23.0 and then we should be good to go.

Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. DO NOT MERGE Do not merge this PR. labels Mar 9, 2025
@codecov

codecovBot commented Mar 9, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.25%. Comparing base (259cd22) to head (91b0abd).
Report is 3 commits behind head on master.

Files with missing linesPatch %Lines
example/ratelimit/main.go0.00%14 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3504 +/- ##
==========================================
+ Coverage 91.21% 91.25% +0.03% 
==========================================
Files 182 183 +1 Lines 15930 16058 +128 ==========================================
+ Hits 14531 14654 +123 - Misses 1225 1230 +5 
Partials 174 174 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gofri

gofri commented Mar 9, 2025

Copy link
Copy Markdown
ContributorAuthor

@gmlewis
Sounds great! Thanks!
I'll try to monitor this repo and ping here when it's relevant (just in case)

gofriand others added 4 commits March 12, 2025 15:01
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewisgmlewis removed the DO NOT MERGE Do not merge this PR. label Mar 12, 2025
Comment threadexample/go.mod Outdated
module github.com/google/go-github/v69/example

go 1.23.0
go 1.23.1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this work with go 1.23.0 ?
We would prefer to use that due to #3423 (comment)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem at all, fixed.
I just misunderstood your previous comment to mean that you want line 3 to remain.

@gmlewis

Copy link
Copy Markdown
Collaborator

go: github.com/gofri/go-github-ratelimit/v2@v2.0.1 requires go >= 1.23.1 (running go 1.23.0; GOTOOLCHAIN=go1.22.0+auto; go.mod sets go 1.23.0)

Is there any way that your package could change its requirements to 1.23.0 ?

@gmlewis

Copy link
Copy Markdown
Collaborator

There's a long thread in #3423 that describes why this is beneficial.

@gofri

Copy link
Copy Markdown
ContributorAuthor

go: github.com/gofri/go-github-ratelimit/v2@v2.0.1 requires go >= 1.23.1 (running go 1.23.0; GOTOOLCHAIN=go1.22.0+auto; go.mod sets go 1.23.0)

Is there any way that your package could change its requirements to 1.23.0 ?

Sure, I don't mind at all. I'll push a new tag and update this branch accordingly.

There's a long thread in #3423 that describes why this is beneficial.

huh thanks for sharing that info.

@gofri

Copy link
Copy Markdown
ContributorAuthor

@gmlewis done! let me know if you need me to fix anything else.

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis done! let me know if you need me to fix anything else.

It looks like the linter is requiring go mod tidy to run in the examples directory.
I think if you run ./script/generate.sh then it will run go mod tidy for you with the correct GOTOOLCHAIN env var setting.

@gofri

Copy link
Copy Markdown
ContributorAuthor

@gmlewis
done! thank you for your patience with this.

@gmlewis

Copy link
Copy Markdown
Collaborator

In the future, please don't force push PRs in this repo as it blows away previous review history.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gofri!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you have time for a code review? Thank you!

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 14, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @stevehipwell!
Merging.

@gmlewis
gmlewis merged commit f88b6c8 into google:masterMar 14, 2025
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Pagination Handlers

3 participants

@gofri@gmlewis@stevehipwell