Skip to content

Bump dependency versions from dependabot warnings - #3512

Merged
gmlewis merged 2 commits into
google:masterfrom
gmlewis:bump-org-x-net
Mar 11, 2025
Merged

Bump dependency versions from dependabot warnings#3512
gmlewis merged 2 commits into
google:masterfrom
gmlewis:bump-org-x-net

Conversation

@gmlewis

Copy link
Copy Markdown
Collaborator

Closes: #3427.
Closes: #3457.
Closes: #3484.
Closes: #3509.
Closes: #3510.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@codecov

codecovBot commented Mar 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.21%. Comparing base (76d1d46) to head (2a433a9).
Report is 1 commits behind head on master.

Files with missing linesPatch %Lines
example/verifyartifact/main.go0.00%2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3512 +/- ##
=======================================
Coverage 91.21% 91.21% =======================================
Files 182 182 Lines 15930 15930 =======================================
Hits 14531 14531 Misses 1225 1225 Partials 174 174 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

@dnwe - @stevehipwell - are you OK with these changes?
The bump to Go 1.23 is required in the examples, tools, and scrape directories due to dependencies with dependabot warnings. I've left the main go.mod alone.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 10, 2025
@dnwe

dnwe commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

@gmlewis as per IBM/sarama#3113, since the Go team started immediately bumping the golang.org/x tree to have go.mod directives of N-1 as soon as a new release is made, I feel it is no longer possible for any of us library authors to maintain support for anything older than N-1.

As such, I'd recommend you keep all the go.mod files in-sync and bump to 1.23.0

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 11, 2025
@gmlewis
gmlewis merged commit 75813d0 into google:masterMar 11, 2025
@gmlewis
gmlewis deleted the bump-org-x-net branch March 11, 2025 00:56
@stevehipwell

Copy link
Copy Markdown
Contributor

Sorry for the slow reply @gmlewis, I agree with the above comment.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gmlewis@dnwe@stevehipwell