Skip to content

Path escape fix in UserService.GetPackage() - #3522

Merged
gmlewis merged 1 commit into
google:masterfrom
Abiji-2020:escape-package-name
Mar 18, 2025
Merged

Path escape fix in UserService.GetPackage() #3522
gmlewis merged 1 commit into
google:masterfrom
Abiji-2020:escape-package-name

Conversation

@Abiji-2020

@Abiji-2020Abiji-2020 commented Mar 18, 2025

Copy link
Copy Markdown
Contributor
  • Run liniting, testing commands
  • Modified the test to ensure the escape sequence.

Fixes: #3262.

Signed-off-by: Abinand P <abinand0911@gmail.com>
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Mar 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (8f3c64e) to head (687dc80).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3522 +/- ##
=======================================
Coverage 91.27% 91.27% =======================================
Files 183 183 Lines 16099 16099 =======================================
Hits 14695 14695 Misses 1230 1230 Partials 174 174 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Abiji-2020!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you have time for a code review? Thank you!

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 18, 2025

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 18, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @stevehipwell!
Merging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OrganizationsService.GetPackage escapes packageName, but UserService.GetPackage does not

3 participants

@Abiji-2020@gmlewis@stevehipwell