Skip to content

Add ListReleaseReactions and DeleteReleaseReaction - #3533

Merged
gmlewis merged 4 commits into
google:masterfrom
colbylwilliams:new-reactions
Mar 27, 2025
Merged

Add ListReleaseReactions and DeleteReleaseReaction #3533
gmlewis merged 4 commits into
google:masterfrom
colbylwilliams:new-reactions

Conversation

@colbylwilliams

@colbylwilliamscolbylwilliams commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

Following up on changes in #3532

This PR adds List and Delete functionality to reactions associated with a release

@codecov

codecovBot commented Mar 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (51d32d9) to head (7193318).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3533 +/- ##
==========================================
+ Coverage 91.30% 91.31% +0.01% 
==========================================
Files 184 184 Lines 16143 16169 +26 ==========================================
+ Hits 14739 14765 +26 
Misses 1230 1230 Partials 174 174 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor tweak, please, @colbylwilliams, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you have time for a code review? Thank you!

Comment threadgithub/reactions.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 26, 2025

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 27, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @stevehipwell!
Merging.

@gmlewis
gmlewis merged commit 4f05dfb into google:masterMar 27, 2025
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@colbylwilliams@gmlewis@stevehipwell