chore: Remove redundant in Go 1.22 loop variables

.golangci.yml

@@ -5,6 +5,7 @@ run:
 linters:
  enable:
  - canonicalheader
+ - copyloopvar
  - dogsled
  - dupl
  - gci
@@ -42,7 +43,7 @@ linters-settings:
  CopyrightDate: "Copyright \\d{4} "
  template: |-
  {{CopyrightDate}}The go-github AUTHORS. All rights reserved.
-
+
  Use of this source code is governed by a BSD-style
  license that can be found in the LICENSE file.
  gosec:

github/actions_artifacts_test.go

@@ -289,7 +289,6 @@ func TestActionsService_DownloadArtifact(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -351,7 +350,6 @@ func TestActionsService_DownloadArtifact_invalidOwner(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, _, _ := setup(t)
@@ -381,7 +379,6 @@ func TestActionsService_DownloadArtifact_invalidRepo(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, _, _ := setup(t)
@@ -411,7 +408,6 @@ func TestActionsService_DownloadArtifact_StatusMovedPermanently_dontFollowRedire
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -448,7 +444,6 @@ func TestActionsService_DownloadArtifact_StatusMovedPermanently_followRedirects(
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, serverURL := setup(t)
@@ -497,7 +492,6 @@ func TestActionsService_DownloadArtifact_unexpectedCode(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, serverURL := setup(t)

github/actions_secrets_test.go

@@ -76,7 +76,6 @@ func TestPublicKey_UnmarshalJSON(t *testing.T) {
 	}
 
 	for name, tt := range testCases {
- tt := tt
  t.Run(name, func(t *testing.T) {
  t.Parallel()
  pk := PublicKey{}

github/actions_workflow_jobs_test.go

@@ -200,7 +200,6 @@ func TestActionsService_GetWorkflowJobLogs(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -261,7 +260,6 @@ func TestActionsService_GetWorkflowJobLogs_StatusMovedPermanently_dontFollowRedi
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -298,7 +296,6 @@ func TestActionsService_GetWorkflowJobLogs_StatusMovedPermanently_followRedirect
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, serverURL := setup(t)
@@ -351,7 +348,6 @@ func TestActionsService_GetWorkflowJobLogs_unexpectedCode(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, serverURL := setup(t)

github/actions_workflow_runs_test.go

@@ -206,7 +206,6 @@ func TestActionsService_GetWorkflowRunAttemptLogs(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -256,7 +255,6 @@ func TestActionsService_GetWorkflowRunAttemptLogs_StatusMovedPermanently_dontFol
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -293,7 +291,6 @@ func TestActionsService_GetWorkflowRunAttemptLogs_StatusMovedPermanently_followR
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, serverURL := setup(t)
@@ -352,7 +349,6 @@ func TestActionsService_GetWorkflowRunAttemptLogs_unexpectedCode(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, serverURL := setup(t)
@@ -521,7 +517,6 @@ func TestActionsService_GetWorkflowRunLogs(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -571,7 +566,6 @@ func TestActionsService_GetWorkflowRunLogs_StatusMovedPermanently_dontFollowRedi
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -608,7 +602,6 @@ func TestActionsService_GetWorkflowRunLogs_StatusMovedPermanently_followRedirect
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, serverURL := setup(t)
@@ -667,7 +660,6 @@ func TestActionsService_GetWorkflowRunLogs_unexpectedCode(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, serverURL := setup(t)

github/codespaces_secrets_test.go

@@ -77,7 +77,6 @@ func TestCodespacesService_ListSecrets(t *testing.T) {
 	}
 
 	for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -177,7 +176,6 @@ func TestCodespacesService_GetSecret(t *testing.T) {
 	}
 
 	for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -277,7 +275,6 @@ func TestCodespacesService_CreateOrUpdateSecret(t *testing.T) {
 	}
 
 	for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -364,7 +361,6 @@ func TestCodespacesService_DeleteSecret(t *testing.T) {
 	}
 
 	for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -450,7 +446,6 @@ func TestCodespacesService_GetPublicKey(t *testing.T) {
 	}
 
 	for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -529,7 +524,6 @@ func TestCodespacesService_ListSelectedReposForSecret(t *testing.T) {
 	}
 
 	for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -616,7 +610,6 @@ func TestCodespacesService_SetSelectedReposForSecret(t *testing.T) {
 	}
 
 	for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -684,7 +677,6 @@ func TestCodespacesService_AddSelectedReposForSecret(t *testing.T) {
 	}
 
 	for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -752,7 +744,6 @@ func TestCodespacesService_RemoveSelectedReposFromSecret(t *testing.T) {
 	}
 
 	for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)

github/copilot_test.go

@@ -114,7 +114,6 @@ func TestCopilotSeatDetails_UnmarshalJSON(t *testing.T) {
 	}
 
 	for _, tc := range tests {
- tc := tc
  seatDetails := &CopilotSeatDetails{}
 
  t.Run(tc.name, func(t *testing.T) {

github/github_test.go

@@ -465,7 +465,6 @@ func TestWithEnterpriseURLs(t *testing.T) {
  wantUploadURL: "https://cloud-api.custom-upload-url/api/uploads/",
  },
 	} {
- test := test
  t.Run(test.name, func(t *testing.T) {
  t.Parallel()
  validate := func(c *Client, err error) {
@@ -2115,7 +2114,6 @@ func TestCompareHttpResponse(t *testing.T) {
 	}
 
 	for name, tc := range testcases {
- tc := tc
  t.Run(name, func(t *testing.T) {
  t.Parallel()
  v := compareHTTPResponse(tc.h1, tc.h2)
@@ -2274,7 +2272,6 @@ func TestErrorResponse_Is(t *testing.T) {
 	}
 
 	for name, tc := range testcases {
- tc := tc
  t.Run(name, func(t *testing.T) {
  t.Parallel()
  if tc.wantSame != err.Is(tc.otherError) {
@@ -2344,7 +2341,6 @@ func TestRateLimitError_Is(t *testing.T) {
 	}
 
 	for name, tc := range testcases {
- tc := tc
  t.Run(name, func(t *testing.T) {
  t.Parallel()
  if tc.wantSame != tc.err.Is(tc.otherError) {
@@ -2431,7 +2427,6 @@ func TestAbuseRateLimitError_Is(t *testing.T) {
 	}
 
 	for name, tc := range testcases {
- tc := tc
  t.Run(name, func(t *testing.T) {
  t.Parallel()
  if tc.wantSame != tc.err.Is(tc.otherError) {
@@ -2463,7 +2458,6 @@ func TestAcceptedError_Is(t *testing.T) {
 	}
 
 	for name, tc := range testcases {
- tc := tc
  t.Run(name, func(t *testing.T) {
  t.Parallel()
  if tc.wantSame != err.Is(tc.otherError) {

github/messages_test.go

@@ -215,7 +215,6 @@ func TestValidatePayload_BadRequestBody(t *testing.T) {
 	}
 
 	for i, tt := range tests {
- tt := tt
  t.Run(fmt.Sprintf("test #%v", i), func(t *testing.T) {
  t.Parallel()
  req := &http.Request{

github/orgs_properties_test.go

@@ -423,7 +423,6 @@ func TestCustomPropertyValue_UnmarshalJSON(t *testing.T) {
 	}
 
 	for name, tc := range tests {
- tc := tc
  t.Run(name, func(t *testing.T) {
  t.Parallel()
  cpv := &CustomPropertyValue{}

github/pulls_reviews_test.go

@@ -330,7 +330,6 @@ func TestPullRequestReviewRequest_isComfortFadePreview(t *testing.T) {
 	}}
 
 	for _, tc := range tests {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  gotBool, gotErr := tc.review.isComfortFadePreview()

github/repos_commits_test.go

@@ -384,7 +384,6 @@ func TestRepositoriesService_CompareCommits(t *testing.T) {
 	}
 
 	for i, sample := range testCases {
- sample := sample
  t.Run(fmt.Sprintf("case #%v", i+1), func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -526,7 +525,6 @@ func TestRepositoriesService_CompareCommitsRaw_diff(t *testing.T) {
 	}
 
 	for i, sample := range testCases {
- sample := sample
  t.Run(fmt.Sprintf("case #%v", i+1), func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -585,7 +583,6 @@ func TestRepositoriesService_CompareCommitsRaw_patch(t *testing.T) {
 	}
 
 	for i, sample := range testCases {
- sample := sample
  t.Run(fmt.Sprintf("case #%v", i+1), func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -632,7 +629,6 @@ func TestRepositoriesService_CompareCommitsRaw_invalid(t *testing.T) {
 	}
 
 	for i, sample := range testCases {
- sample := sample
  t.Run(fmt.Sprintf("case #%v", i+1), func(t *testing.T) {
  t.Parallel()
  client, _, _ := setup(t)

github/repos_contents_test.go

@@ -722,7 +722,6 @@ func TestRepositoriesService_GetArchiveLink(t *testing.T) {
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -780,7 +779,6 @@ func TestRepositoriesService_GetArchiveLink_StatusMovedPermanently_dontFollowRed
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, _ := setup(t)
@@ -816,7 +814,6 @@ func TestRepositoriesService_GetArchiveLink_StatusMovedPermanently_followRedirec
 	}
 
 	for _, tc := range tcs {
- tc := tc
  t.Run(tc.name, func(t *testing.T) {
  t.Parallel()
  client, mux, serverURL := setup(t)

github/repos_environments_test.go

@@ -70,7 +70,6 @@ func TestRequiredReviewer_UnmarshalJSON(t *testing.T) {
 	}
 
 	for name, test := range testCases {
- test := test
  t.Run(name, func(t *testing.T) {
  t.Parallel()
  rule := []*RequiredReviewer{}

github/repos_hooks_deliveries_test.go

@@ -205,7 +205,6 @@ var hookDeliveryPayloadTypeToStruct = map[string]interface{}{
 func TestHookDelivery_ParsePayload(t *testing.T) {
 	t.Parallel()
 	for evt, obj := range hookDeliveryPayloadTypeToStruct {
- evt, obj := evt, obj
  t.Run(evt, func(t *testing.T) {
  t.Parallel()
  bs, err := json.Marshal(obj)