Skip to content

feat: Add new fields and options to secret scanning structs - #3548

Merged
gmlewis merged 10 commits into
google:masterfrom
mdfleury-wbd:add-secret-fields
Apr 15, 2025
Merged

feat: Add new fields and options to secret scanning structs#3548
gmlewis merged 10 commits into
google:masterfrom
mdfleury-wbd:add-secret-fields

Conversation

@mdfleury-wbd

Copy link
Copy Markdown
Contributor

Added some new fields to secret scanning alerts

@gmlewisgmlewis changed the title feat: adding new fields and options in secret scanningfeat: Add new fields and options to secret scanning structsApr 14, 2025
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
@codecov

codecovBot commented Apr 14, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (6a7684f) to head (e7a50e8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3548 +/- ##
=======================================
Coverage 91.23% 91.23% =======================================
Files 183 183 Lines 16053 16053 =======================================
Hits 14646 14646 Misses 1231 1231 Partials 176 176 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mdfleury-wbdand others added 7 commits April 15, 2025 08:00
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis

Copy link
Copy Markdown
Collaborator

Please run:

  • ./script/fmt.sh
  • ./script/generate.sh
    and push the changes to this PR, then we should be good to go.

@mdfleury-wbd

Copy link
Copy Markdown
ContributorAuthor

The broken tests seem to be coming from #3551
which is here
https://github.com/codecov/codecov-action/compare/v5.4.0..v5.4.2

@gmlewis

gmlewis commented Apr 15, 2025

Copy link
Copy Markdown
Collaborator

The broken tests seem to be coming from #3551 which is here https://github.com/codecov/codecov-action/compare/v5.4.0..v5.4.2

Thank you, @mdfleury-wbd!
I've reverted that change. Would you mind merging the latest master branch into this PR to see if that fixes the problem?

@gmlewis

Copy link
Copy Markdown
Collaborator

Oh wait, I forgot that I can do that... one moment...

@gmlewis

Copy link
Copy Markdown
Collaborator

That fixed it! Woohoo!

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mdfleury-wbd!
LGTM.
Merging.

@gmlewis
gmlewis merged commit 687f933 into google:masterApr 15, 2025
@mdfleury-wbd
mdfleury-wbd deleted the add-secret-fields branch April 15, 2025 17:25
@gmlewis

Copy link
Copy Markdown
Collaborator

Just out of curiosity, how often do you cut new releases?

Typically about once per month but we can cut new releases on-demand when there is an urgent need.

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mdfleury-wbd@gmlewis