Uh oh!
There was an error while loading. Please reload this page.
feat: Add support for sub-issue - #3580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3580 +/- ##
==========================================
+ Coverage 91.29% 91.32% +0.03%
==========================================
Files 183 184 +1 Lines 16087 16143 +56 ==========================================
+ Hits 14686 14742 +56
Misses 1227 1227 Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
commented
May 20, 2025
Thank you, @e7217! Please follow the instructions in step 4 of CONTRIBUTING.md and push the changes to this PR. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
e7217
commented
May 20, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
e7217
commented
May 21, 2025
@gmlewis |
| // TODO: remove custom Accept header when this API fully launches. | ||
| req.Header.Set("Accept", mediaTypeV3) |
There was a problem hiding this comment.
Looking at the documentation for these endpoints, I'm not seeing any need to add the mediaTypeV3 header, so all these lines can safely be removed, I believe. Feel free to correct me if I've missed them.
There was a problem hiding this comment.
Looking at the documentation for these endpoints, I'm not seeing any need to add the
mediaTypeV3header, so all these lines can safely be removed, I believe. Feel free to correct me if I've missed them.
The header values are included as shown below, and I used the predefined header values from go-github. Since the response was coming back correctly, I applied them as is. If you think it would be better to remove this, I will delete that part. Please let me know your opinion.
There was a problem hiding this comment.
Right, but the one you added doesn't match.
You added application/vnd.github.v3+json, so I think this one can be removed.
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @e7217!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
gmlewis
commented
May 26, 2025
Thank you, @DiegoDev2! |
Hello,
I have added some features to support
Sub-issue.The following features have been added:
Sorry for the delay in developing this feature.
Thank you for your review😀
Fixes#3546
cc@gmlewis