Skip to content

fix: Add missing relationship and pkg external info for SBOMs - #3582

Merged
gmlewis merged 7 commits into
google:masterfrom
viveksahu26:fix/dependency-graph-sbom-complete_issue_3581
May 31, 2025
Merged

fix: Add missing relationship and pkg external info for SBOMs#3582
gmlewis merged 7 commits into
google:masterfrom
viveksahu26:fix/dependency-graph-sbom-complete_issue_3581

Conversation

@viveksahu26

@viveksahu26viveksahu26 commented May 29, 2025

Copy link
Copy Markdown
Contributor

Fixes: #3581

This PR adds the following changes:

  • It adds up Relationship section in the SBOMs.
  • It also includes externalRefs under the package information.

TODO: Testing need to be added.

@viveksahu26
viveksahu26 marked this pull request as draft May 29, 2025 17:13
@gmlewisgmlewis changed the title [fix]: add mising relationship and pkg external infofix: Add missing relationship and pkg external info for SBOMsMay 29, 2025
@codecov

codecovBot commented May 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (cc0e642) to head (c11ffa5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3582 +/- ##
=======================================
Coverage 91.32% 91.32% =======================================
Files 184 184 Lines 16143 16143 =======================================
Hits 14742 14742 Misses 1227 1227 Partials 174 174 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @viveksahu26!
I know this PR is still a draft, but I wanted to give some early feedback before you got too far in writing the new tests.

Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go Outdated
Comment threadgithub/dependency_graph.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label May 31, 2025
@viveksahu26
viveksahu26 marked this pull request as ready for review May 31, 2025 17:30
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label May 31, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @viveksahu26!
LGTM.
Merging.

@gmlewis
gmlewis merged commit b52ed30 into google:masterMay 31, 2025
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DependencyGraph.GetSBOM() missing important SBOM fields like relationship and package externalRefs

2 participants

@viveksahu26@gmlewis