Skip to content

feat!: Add repository query option to ListCustomPropertyValues - #3598

Merged
gmlewis merged 3 commits into
google:masterfrom
kazuki-hanai:introduce-repo-query
Jun 24, 2025
Merged

feat!: Add repository query option to ListCustomPropertyValues#3598
gmlewis merged 3 commits into
google:masterfrom
kazuki-hanai:introduce-repo-query

Conversation

@kazuki-hanai

@kazuki-hanaikazuki-hanai commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: ListCustomPropertyValues now takes ListCustomPropertyValuesOptions instead of ListOptions.

Fixes: #3596

What

SSIA

Why

I want to use repository_query option for OrganizationService. ListCustomPropertyValues.

related issue: #3596

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Jun 24, 2025
@codecov

codecovBot commented Jun 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (ad671c4) to head (d3d65e6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3598 +/- ##
=======================================
Coverage 91.32% 91.32% =======================================
Files 184 184 Lines 16143 16143 =======================================
Hits 14742 14742 Misses 1227 1227 Partials 174 174 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kazuki-hanai!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell or @alexandear - might one of you have time for a code review? Thank you!

Comment threadgithub/orgs_properties.go Outdated
kazuki-hanaiand others added 2 commits June 24, 2025 21:29
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
@kazuki-hanai

Copy link
Copy Markdown
ContributorAuthor

@alexandear Thank you for your review!
I fixed other in d3d65e6

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 24, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @alexandear and @stevehipwell!
LGTM.
Merging.

@gmlewisgmlewis changed the title Add repository query option to ListCustomPropertyValuesfeat!: Add repository query option to ListCustomPropertyValuesJun 24, 2025
@gmlewis
gmlewis merged commit 1b8d6fb into google:masterJun 24, 2025
@kazuki-hanai
kazuki-hanai deleted the introduce-repo-query branch June 25, 2025 01:32
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
…e#3598)
BREAKING CHANGE: `ListCustomPropertyValues` now takes `ListCustomPropertyValuesOptions` instead of `ListOptions`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why repository_query option haven't been implemented?

4 participants

@kazuki-hanai@gmlewis@alexandear@stevehipwell