Uh oh!
There was an error while loading. Please reload this page.
feat!: Add repository query option to ListCustomPropertyValues - #3598
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3598 +/- ##
=======================================
Coverage 91.32% 91.32% =======================================
Files 184 184 Lines 16143 16143 =======================================
Hits 14742 14742 Misses 1227 1227 Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @kazuki-hanai!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell or @alexandear - might one of you have time for a code review? Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
…ions for consistent naming
kazuki-hanai
commented
Jun 24, 2025
@alexandear Thank you for your review! |
gmlewis
commented
Jun 24, 2025
Thank you, @alexandear and @stevehipwell! |
…e#3598) BREAKING CHANGE: `ListCustomPropertyValues` now takes `ListCustomPropertyValuesOptions` instead of `ListOptions`.
BREAKING CHANGE:
ListCustomPropertyValuesnow takesListCustomPropertyValuesOptionsinstead ofListOptions.Fixes: #3596
What
SSIA
Why
I want to use
repository_queryoption forOrganizationService. ListCustomPropertyValues.related issue: #3596