Uh oh!
There was an error while loading. Please reload this page.
fix!: Add ListSCIMProvisionedGroupsForEnterpriseOptions - #3601
Conversation
d13fa0a to
a019a66CompareCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3601 +/- ##
=======================================
Coverage 91.32% 91.32% =======================================
Files 184 184 Lines 16143 16146 +3 =======================================
+ Hits 14742 14745 +3
Misses 1227 1227 Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
@alexandear - will you need a new release once this gets merged? I know we just had one, but I'm totally fine with bumping the release since this just missed that one.
alexandear
commented
Jun 25, 2025
Thanks for checking! I don’t need a new release - happy to wait for the next one. |
a019a66 to
da02fedComparealexandear
commented
Jun 25, 2025
Rebased to resolve conflicts. |
gmlewis
commented
Jun 25, 2025
Thank you, @stevehipwell! |
BREAKING CHANGE: `ListSCIMProvisionedGroupsForEnterprise` now takes `ListSCIMProvisionedGroupsForEnterpriseOptions` instead of `*ListSCIMProvisionedIdentitiesOptions`.
BREAKING CHANGE:
ListSCIMProvisionedGroupsForEnterprisenow takesListSCIMProvisionedGroupsForEnterpriseOptionsinstead of*ListSCIMProvisionedIdentitiesOptions.This PR fixes two issues:
ListSCIMProvisionedGroupsForEnterprisewere not beeing handled.ListSCIMProvisionedIdentitiesOptionswas missing theexcludedAttributesproperty.See https://docs.github.com/en/enterprise-cloud@latest/rest/enterprise-admin/scim?apiVersion=2022-11-28#list-provisioned-scim-groups-for-an-enterprise--parameters