Uh oh!
There was an error while loading. Please reload this page.
Add new enhanced billing endpoints - #3605
Conversation
gmlewis
commented
Jun 26, 2025
Thank you, @DocEmmetBrown! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3605 +/- ##
==========================================
+ Coverage 91.32% 91.34% +0.01%
==========================================
Files 184 184 Lines 16148 16180 +32 ==========================================
+ Hits 14747 14779 +32
Misses 1227 1227 Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
the new endpoints are available as per this doc: https://docs.github.com/en/enterprise-cloud@latest/rest/billing/enhanced-billing?apiVersion=2022-11-28#get-billing-usage-report-for-an-organization
99177f0 to
9c9cddfCompareDocEmmetBrown
commented
Jun 26, 2025
this is done :) |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @DocEmmetBrown!
Just a few minor tweaks, please then we should be ready for a second LGTM+Approval before merging.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
06d5fb1 to
2a368b7CompareDocEmmetBrown
commented
Jun 27, 2025
@gmlewis: I think I addressed all the concerns. I'm unsure how to re-run codecov to see if the changes "fixed" the coverage issue 🤔 |
DocEmmetBrown
commented
Jun 27, 2025
fixes #3592 |
Uh oh!
There was an error while loading. Please reload this page.
alexandear
commented
Jun 27, 2025
Please add this to the PR description, so GitHub will automatically close the issue when the PR is merged. |
alexandear
commented
Jun 27, 2025
Could you test these endpoints manually? |
DocEmmetBrown
commented
Jun 27, 2025
@alexandear: what do you mean ? writing a quick go file that would hit those endpoints ? or testing the github api from the cli ? |
gmlewis
commented
Jun 27, 2025
As described in CONTRIBUTING.md: |
DocEmmetBrown
commented
Jun 27, 2025
oh, yeah, this was done, sorry for the confusion :) |
gmlewis
commented
Jun 27, 2025
Normally, when contributors simply "push" changes to a PR, reviewers can click on this button in GitHub in order to see only the parts that have changed since the last code review: However, when contributors use "force push", this is what reviewers see: In this repo, we ALWAYS use squash-and-merge so that the commit history is nice and clean, as demonstrated below, which is why we ask that all contributors (in CONTRIBUTING.md) please not use "force push", in order to make the lives of code reviewers easier. Thank you. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @DocEmmetBrown and @alexandear!
LGTM.
Merging.
DocEmmetBrown
commented
Jun 27, 2025
Sorry about that @gmlewis , I should have paid more attention to the docs. Old habits die hard ;) Thanks for merging it ! |
gmlewis
commented
Jun 27, 2025
No problem. We have a few contributors who do this on a regular basis, and I'm hoping that if I explain why I keep asking for no "force pushing" maybe someday they will remember to stop doing that. Thank you, @DocEmmetBrown! |



The new Enhanced billing platform is available as per the doc
This is (largely) generated by copilot, but still manually reviewed. Happy to make any change if needed.
Fixes: #3592