Skip to content

refactor: Fix revive.unnecessary-format lint issues - #3629

Merged
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:refactor/revive-unnecessary-format
Jul 19, 2025
Merged

refactor: Fix revive.unnecessary-format lint issues#3629
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:refactor/revive-unnecessary-format

Conversation

@alexandear

Copy link
Copy Markdown
Contributor

Changes:

  • Enabled the revive.unnecessary rule in golangci-lint config. This requires upgrading golangci-lint to version 2.2.2.
  • Fixes assert messages in TestRepositoriesService_GetAutomatedSecurityFixes.
  • Replaced t.Errorf with t.Error.
  • Replaced t.Fatalf with t.Fatal.
  • Replaced fmt.Fprintf with fmt.Fprint.
  • Replaced log.Fatalf with log.Fatal.

@codecov

codecovBot commented Jul 19, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.33%. Comparing base (18877d9) to head (76c24d6).
⚠️ Report is 333 commits behind head on master.

Files with missing linesPatch %Lines
example/commitpr/main.go0.00%1 Missing ⚠️
example/verifyartifact/main.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3629 +/- ##
=======================================
Coverage 91.33% 91.33% =======================================
Files 184 184 Lines 16174 16174 =======================================
Hits 14773 14773 Misses 1227 1227 Partials 174 174 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis changed the title refactor: fix revive.unnecessary-format lint issuesrefactor: Fix revive.unnecessary-format lint issuesJul 19, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

@gmlewis
gmlewis merged commit ff1666c into google:masterJul 19, 2025
6 of 7 checks passed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandear@gmlewis