Skip to content

fix: Add validation for nil inputs in various services - #3636

Merged
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:change/handle-nil-ptr
Jul 24, 2025
Merged

fix: Add validation for nil inputs in various services#3636
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:change/handle-nil-ptr

Conversation

@alexandear

Copy link
Copy Markdown
Contributor

Add nil checks to avoid nil pointer dereference and for consistency with other places:

@codecov

codecovBot commented Jul 23, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 82.22222% with 24 lines in your changes missing coverage. Please review.

Project coverage is 91.26%. Comparing base (6540c41) to head (f56e6b5).
Report is 8 commits behind head on master.

Files with missing linesPatch %Lines
github/codespaces_secrets.go27.27%16 Missing and 8 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3636 +/- ##
==========================================
- Coverage 91.33% 91.26% -0.08% 
==========================================
Files 184 184 Lines 16174 16309 +135 ==========================================
+ Hits 14773 14884 +111 - Misses 1227 1243 +16 - Partials 174 182 +8 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment threadgithub/repos_releases.go

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you have time for a code review? Thank you!

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 24, 2025

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
gmlewis merged commit d88d529 into google:masterJul 24, 2025
5 of 7 checks passed
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 22, 2025
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandear@stevehipwell@gmlewis