Skip to content

Add location info to SecretScanningAlert - #3645

Merged
gmlewis merged 4 commits into
google:masterfrom
mdfleury-wbd:master
Jul 24, 2025
Merged

Add location info to SecretScanningAlert#3645
gmlewis merged 4 commits into
google:masterfrom
mdfleury-wbd:master

Conversation

@mdfleury-wbd

Copy link
Copy Markdown
Contributor

@gmlewisgmlewis changed the title Adding new location info for secret alertsAdd location info to SecreateScanningAlertJul 24, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mdfleury-wbd!
Just one minor tweak, please, then we should be good to merge.

Comment threadgithub/secret_scanning.go Outdated
@codecov

codecovBot commented Jul 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (d88d529) to head (369ac68).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3645 +/- ##
=======================================
Coverage 91.25% 91.25% =======================================
Files 184 184 Lines 16311 16311 =======================================
Hits 14884 14884 Misses 1245 1245 Partials 182 182 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexandear

Copy link
Copy Markdown
Contributor

Please fix a typo in the title: SecreateScanningAlert -> SecretScanningAlert

@gmlewisgmlewis changed the title Add location info to SecreateScanningAlertAdd location info to SecretScanningAlertJul 24, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mdfleury-wbd and @alexandear!
LGTM.
Merging.

@gmlewis
gmlewis merged commit d1d6f45 into google:masterJul 24, 2025
7 checks passed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mdfleury-wbd@alexandear@gmlewis