Uh oh!
There was an error while loading. Please reload this page.
Add location info to SecretScanningAlert - #3645
Merged
Merged
Conversation
SecreateScanningAlertgmlewis
requested changes
Jul 24, 2025
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @mdfleury-wbd!
Just one minor tweak, please, then we should be good to merge.
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3645 +/- ##
=======================================
Coverage 91.25% 91.25% =======================================
Files 184 184 Lines 16311 16311 =======================================
Hits 14884 14884 Misses 1245 1245 Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexandear
commented
Jul 24, 2025
Contributor
Please fix a typo in the title: |
SecreateScanningAlertSecretScanningAlertgmlewis
approved these changes
Jul 24, 2025
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @mdfleury-wbd and @alexandear!
LGTM.
Merging.
Uh oh!
There was an error while loading. Please reload this page.
jlaportebot added a commit
to jlaportebot/go-github
that referenced
this pull request
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.blog/changelog/2025-06-24-secret-scanning-rest-api-responses-including-first_location_detected-and-has_more_locations-are-now-generally-available/
Adding the new information for first location detected and has more locations in the secret alerts API