Skip to content

refactor: Fix gocritic.paramTypeCombine lint issues - #3655

Merged
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:refactor/param-type-combine
Jul 28, 2025
Merged

refactor: Fix gocritic.paramTypeCombine lint issues#3655
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:refactor/param-type-combine

Conversation

@alexandear

Copy link
Copy Markdown
Contributor

This PR combines function parameters by type (with the help of gocritic.paramTypeCombine). See #3654 (comment)

@alexandear
alexandearforce-pushed the refactor/param-type-combine branch from 3e2e68c to c77318bCompareJuly 28, 2025 15:15

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

@codecov

codecovBot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.25%. Comparing base (ac631dc) to head (c77318b).
⚠️ Report is 1 commits behind head on master.

Files with missing linesPatch %Lines
...xample/codespaces/newreposecretwithxcrypto/main.go0.00%2 Missing ⚠️
example/newreposecretwithxcrypto/main.go0.00%2 Missing ⚠️
...xample/codespaces/newusersecretwithxcrypto/main.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3655 +/- ##
=======================================
Coverage 91.25% 91.25% =======================================
Files 184 184 Lines 16311 16311 =======================================
Hits 14884 14884 Misses 1245 1245 Partials 182 182 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis
gmlewis merged commit a81b973 into google:masterJul 28, 2025
7 checks passed
@alexandear
alexandear deleted the refactor/param-type-combine branch July 28, 2025 15:34
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandear@gmlewis