Skip to content

feat: Add GitHub Classroom GetAssignment API endpoint - #3685

Merged
gmlewis merged 2 commits into
google:masterfrom
jferrl:jferrl-3684
Aug 18, 2025
Merged

feat: Add GitHub Classroom GetAssignment API endpoint#3685
gmlewis merged 2 commits into
google:masterfrom
jferrl:jferrl-3684

Conversation

@jferrl

@jferrljferrl commented Aug 17, 2025

Copy link
Copy Markdown
Contributor

Implements GET /assignments/{assignment_id} endpoint for retrieving GitHub Classroom assignment details.

Changes

  • New service: ClassroomService with GetAssignment() method
  • New structs: ClassroomAssignment and Classroom with organization details

Issue #3684

# Add GitHub Classroom GetAssignment API endpoint
Implements `GET /assignments/{assignment_id}` endpoint for retrieving GitHub Classroom assignment details.
## Changes
- **New service**: `ClassroomService` with `GetAssignment()` method
- **New structs**: `Assignment` (19 fields) and `Classroom` with organization details
@gmlewisgmlewis changed the title feat: add GitHub Classroom GetAssignment API endpointfeat: Add GitHub Classroom GetAssignment API endpointAug 17, 2025
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 17, 2025
@codecov

codecovBot commented Aug 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.08%. Comparing base (69dc04b) to head (bef279d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3685 +/- ##
=======================================
Coverage 91.07% 91.08% =======================================
Files 186 187 +1 Lines 16563 16581 +18 =======================================
+ Hits 15085 15103 +18 
Misses 1293 1293 Partials 185 185 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jferrl!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@alexandear or @stevehipwell - might you have time for a code review? Thank you!

Comment threadgithub/classroom.go Outdated
Refactors the Assignment struct and related methods to ClassroomAssignment for improved clarity and consistency. Updates all accessors, service methods, and tests to use the new name.

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 18, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @stevehipwell!
Merging.

@gmlewis
gmlewis merged commit dc807dd into google:masterAug 18, 2025
7 checks passed
@jferrl
jferrl deleted the jferrl-3684 branch August 18, 2025 20:49
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jferrl@gmlewis@stevehipwell