feat: Add two new Secret Scanning API endpoints by Not-Dhananjay-Mishra · Pull Request #3687 · google/go-github

Not-Dhananjay-Mishra · 2025-08-18T00:51:58Z

This PR adds support for two new Secret Scanning API endpoints that are currently missing from the go-github library

Implement

POST /repos/{owner}/{repo}/secret-scanning/push-protection-bypasses
GET /repos/{owner}/{repo}/secret-scanning/scan-history

Changes

Add CreatePushProtectionBypass method
Add GetScanHistory method
Made two new struct for PushProtectionBypasses method - PushProtectionBypassRequest and PushProtectionBypass
Made three new struct for ScanHistory method - Scan, CustomPatternScan and SecretScanningResponse

Issue - #3686

codecov · 2025-08-18T11:12:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.37%. Comparing base (29b4fac) to head (be5f36d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #3687 +/- ##
==========================================
+ Coverage 91.36% 91.37% +0.01% 
==========================================
Files 187 187 Lines 16734 16760 +26 ==========================================
+ Hits 15289 15315 +26 
Misses 1257 1257 Partials 188 188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Not-Dhananjay-Mishra · 2025-08-18T11:35:13Z

@alexandear Thanks for the suggestions. I have changed the method names. Please let me know if you have any other suggestions.

gmlewis

Thank you, @Not-Dhananjay-Mishra.
This is a good start. Please address the findings and then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Not-Dhananjay-Mishra · 2025-08-18T14:43:48Z

Thanks @gmlewis for the feedback! I have fixed all the findings. Sorry for the extra back and forth code review.

gmlewis

Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

gmlewis · 2025-08-18T17:22:30Z

Just FYI - suddenly I have lost write access to this repo, like in #3689... so I can no longer approve the workflows and need to find out what is going on... this may take some time to resolve... I apologize for the inconvenience.

gmlewis · 2025-09-22T18:36:34Z

@alexandear - do you now approve this PR for merging?

Not-Dhananjay-Mishra · 2025-09-30T11:49:59Z

@alexandear i have done some changes can u please check them.

gmlewis · 2025-10-07T11:47:58Z

@Not-Dhananjay-Mishra - please fix the linter and test failures and push the changes to this PR.

Not-Dhananjay-Mishra · 2025-10-07T12:05:40Z

@gmlewis all fixed

gmlewis · 2025-10-07T12:40:16Z

Thank you, @Not-Dhananjay-Mishra and @alexandear!
Merging.

Not-Dhananjay-Mishra added 2 commits August 18, 2025 05:47

add PushProtectionBypasses and ScanHistory in secret scanning endpoints
f97ab6d

use timestamp instead of time.Time
895f152

alexandear reviewed Aug 18, 2025
View reviewed changes

Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated

Not-Dhananjay-Mishra added 2 commits August 18, 2025 16:58

change method names
3a24cda

fix comments
52ce83a

alexandear reviewed Aug 18, 2025
View reviewed changes

Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated

Not-Dhananjay-Mishra added 3 commits August 18, 2025 18:40

add comments to struct and change some name
9908a2d

fix comments
25437f3

fix comments
317ee25

Not-Dhananjay-Mishra requested a review from alexandear August 18, 2025 13:31

Not-Dhananjay-Mishra added 3 commits August 18, 2025 19:10

Merge branch 'master' into feat-3686
3ba69ca

Merge branch 'master' into feat-3686
4aa75c6

add omitempty
6f7860e

gmlewis requested changes Aug 18, 2025
View reviewed changes

Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning_test.go
Comment threadgithub/secret_scanning.go Outdated

gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 18, 2025

use omitempty where needed and adjust names
c7213dc

Not-Dhananjay-Mishra requested a review from gmlewis August 18, 2025 14:51

gmlewis approved these changes Aug 18, 2025
View reviewed changes

alexandear reviewed Aug 18, 2025
View reviewed changes

Comment threadgithub/secret_scanning.go Outdated

fix responsePushProtectionBypass
1d091ff

alexandear mentioned this pull request Aug 18, 2025
chore: Format code with gofumpt #3689
Merged

Merge branch 'master' into feat-3686
6606dd4

Not-Dhananjay-Mishra requested a review from alexandear August 19, 2025 13:05

Merge branch 'master' into feat-3686
399ec39

Merge branch 'master' into feat-3686
a4badd1

Merge branch 'master' into feat-3686
3ccea73

gmlewis added the waiting for reply label Sep 23, 2025

alexandear suggested changes Sep 25, 2025
View reviewed changes

Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go Outdated
Comment threadgithub/secret_scanning.go
Comment threadgithub/secret_scanning_test.go Outdated

change struct name
d92b8d2

Not-Dhananjay-Mishra added 2 commits September 30, 2025 17:20

Merge branch 'master' into feat-3686
7dfdcfd

Merge branch 'master' into feat-3686
82cb264

Not-Dhananjay-Mishra requested a review from alexandear October 1, 2025 15:58

alexandear approved these changes Oct 6, 2025
View reviewed changes

Merge branch 'master' into feat-3686
cfa6d5e

gmlewis changed the title ~~feat: Add GitHub two new Secret Scanning API endpoints~~feat: Add two new Secret Scanning API endpointsOct 7, 2025

Not-Dhananjay-Mishra added 2 commits October 7, 2025 17:22

Merge branch 'google:master' into feat-3686
71aa241

change context
be5f36d

gmlewis removed waiting for reply NeedsReview PR is awaiting a review before merging. labels Oct 7, 2025

gmlewis merged commit 84acce0 into google:masterOct 7, 2025
7 checks passed

gmlewis mentioned this pull request Oct 14, 2025
Bump version of go-github to v76.0.0 #3782
Merged

Not-Dhananjay-Mishra deleted the feat-3686 branch February 5, 2026 15:30

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
feat: Add two new Secret Scanning API endpoints (google#3687)
89203b6

Uh oh!

Conversation

Not-Dhananjay-Mishra commented Aug 18, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implement

Changes

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Aug 18, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Not-Dhananjay-Mishra commented Aug 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Not-Dhananjay-Mishra commented Aug 18, 2025

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gmlewis commented Aug 18, 2025

Uh oh!

gmlewis commented Sep 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Not-Dhananjay-Mishra commented Sep 30, 2025

Uh oh!

gmlewis commented Oct 7, 2025

Uh oh!

Not-Dhananjay-Mishra commented Oct 7, 2025

Uh oh!

gmlewis commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Not-Dhananjay-Mishra commented Aug 18, 2025•
edited
Loading

codecovBot commented Aug 18, 2025•
edited
Loading