Skip to content

feat! Add IssueListByOrgOptions and update ListByOrg to use it - #3694

Closed
cpanato wants to merge 1 commit into
google:masterfrom
cpanato:add-type
Closed

feat! Add IssueListByOrgOptions and update ListByOrg to use it#3694
cpanato wants to merge 1 commit into
google:masterfrom
cpanato:add-type

Conversation

@cpanato

@cpanatocpanato commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: ListByOrg now uses IssueListByOrgOptions instead of ListOptions.

we now can pass the Type of an issue to list issues for repo and orgs, so we can have a better filtering

https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#list-repository-issues

@cpanato

Copy link
Copy Markdown
ContributorAuthor

cc @gmlewis

@gmlewis

Copy link
Copy Markdown
Collaborator

Just FYI - I lost write access to this repo and this may cause unexpected delays for which I apologize.
You can watch that other PR to check on the status.

@cpanato

Copy link
Copy Markdown
ContributorAuthor

no worries, thanks for the heads up

@cpanato

Copy link
Copy Markdown
ContributorAuthor

@gmlewis hello any updates on your permission?

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis hello any updates on your permission?

No. You can watch #3689 to check on the status.
I'm still attempting to get the attention of the owners of the repo to add me back as a maintainer.

@cpanato

Copy link
Copy Markdown
ContributorAuthor

thanks, that is sad :(

@gmlewisgmlewis changed the title add type to IssueListByRepoOptions and update ListByOrg to support type filter as wellfeat! Add IssueListByRepoOptions and update ListByOrg to use itSep 22, 2025
@gmlewisgmlewis changed the title feat! Add IssueListByRepoOptions and update ListByOrg to use itfeat! Add IssueListByOrgOptions and update ListByOrg to use itSep 22, 2025
@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Sep 22, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

@cpanato - do you have time to resolve conflicts in this PR, or would you rather I do that?

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cpanato!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging. (Either you or I could resolve conflicts as previously mentioned.)

@stevehipwell and/or @alexandear - might you have time for a code review? Thank you!

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…pe filter as well
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato

Copy link
Copy Markdown
ContributorAuthor

@gmlewis PTAL,rebased

Comment threadgithub/issues.go
return issues, resp, nil
}

// IssueListByOrgOptions specifies the optional parameters to the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// IssueListByOrgOptions specifies the optional parameters to the
// IssueListByOrgOptions specifies the optional parameter to the

Comment threadgithub/issues.go
return s.listIssues(ctx, u, opts)
}

func (s *IssuesService) listIssues(ctx context.Context, u string, opts *IssueListOptions) ([]*Issue, *Response, error) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the change, listIssues is used only in the IssuesService.List. So, let's merge listIssues and List functions.

@codecov

codecovBot commented Sep 23, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.11%. Comparing base (ffc5df8) to head (99e98f3).
⚠️ Report is 209 commits behind head on master.

Files with missing linesPatch %Lines
github/issues.go83.33%2 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3694 +/- ##
==========================================
- Coverage 91.12% 91.11% -0.02% 
==========================================
Files 187 187 Lines 16640 16655 +15 ==========================================
+ Hits 15164 15176 +12 - Misses 1291 1293 +2 - Partials 185 186 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).NeedsReviewPR is awaiting a review before merging.waiting for reply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cpanato@gmlewis@alexandear@stevehipwell