Uh oh!
There was an error while loading. Please reload this page.
feat: Add ClientID to Installation - #3712
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joshlarsen!
LGTM.
Please note that I still don't have write access to this repo, but figure I might as well attempt to catch up on my code reviews (which I usually allow the linter to process first... ah, well).
NOTE TO SELF: Rename "add" => "Add" for PR title consistency in this repo.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #3712 +/- ##
=======================================
Coverage 91.12% 91.12% =======================================
Files 187 187 Lines 16640 16640 =======================================
Hits 15164 15164 Misses 1291 1291 Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ClientID to InstallationClientID to InstallationClientID to Installationgmlewis
commented
Sep 22, 2025
@joshlarsen - I apologize, but could you please re-run step4 to update the auto-generated files and push the changes to this PR? Thank you! |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joshlarsen!
LGTM.
Merging.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds
ClientIDto theInstallationtype.Last year, GitHub added support for using the app
ClientIDto simplify the installation token flow. More detail in this blog post.The test cases that involve
Installationare also updated.