Skip to content

feat: Add ClientID to Installation - #3712

Merged
gmlewis merged 5 commits into
google:masterfrom
joshlarsen:add-client-id-to-installation
Sep 22, 2025
Merged

feat: Add ClientID to Installation#3712
gmlewis merged 5 commits into
google:masterfrom
joshlarsen:add-client-id-to-installation

Conversation

@joshlarsen

Copy link
Copy Markdown
Contributor

This PR adds ClientID to the Installation type.

Last year, GitHub added support for using the app ClientID to simplify the installation token flow. More detail in this blog post.

The test cases that involve Installation are also updated.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joshlarsen!
LGTM.

Please note that I still don't have write access to this repo, but figure I might as well attempt to catch up on my code reviews (which I usually allow the linter to process first... ah, well).

NOTE TO SELF: Rename "add" => "Add" for PR title consistency in this repo.

@joshlarsenjoshlarsen changed the title fix: add ClientID to InstallationAdd ClientID to InstallationSep 18, 2025
@joshlarsenjoshlarsen changed the title Add ClientID to Installationfeat: Add ClientID to InstallationSep 18, 2025
@codecov

codecovBot commented Sep 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.12%. Comparing base (eef4b66) to head (b3b4d11).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3712 +/- ##
=======================================
Coverage 91.12% 91.12% =======================================
Files 187 187 Lines 16640 16640 =======================================
Hits 15164 15164 Misses 1291 1291 Partials 185 185 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis changed the title feat: Add ClientID to Installationfeat: Add ClientID to InstallationSep 22, 2025
@gmlewisgmlewis changed the title feat: Add ClientID to Installationfeat: Add ClientID to InstallationSep 22, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

@joshlarsen - I apologize, but could you please re-run step4 to update the auto-generated files and push the changes to this PR? Thank you!

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joshlarsen!
LGTM.
Merging.

@gmlewis
gmlewis merged commit ffc5df8 into google:masterSep 22, 2025
7 checks passed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@joshlarsen@gmlewis