Skip to content

Add exempt as bypass mode to ruleset bypass actors - #3719

Merged
gmlewis merged 2 commits into
google:masterfrom
nordnet:add-exempt-option
Sep 22, 2025
Merged

Add exempt as bypass mode to ruleset bypass actors#3719
gmlewis merged 2 commits into
google:masterfrom
nordnet:add-exempt-option

Conversation

@claystation

Copy link
Copy Markdown
Contributor

Fixes#3714

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @claystation!
One minor tweak, please, otherwise LGTM.

Note that I still don't have write access to this repo, but figure I might as well attempt to catch up on my code reviews (which I usually allow the linter to process first... ah, well).

Comment threadgithub/rules.go
@claystation

Copy link
Copy Markdown
ContributorAuthor

@gmlewis no rush. Hope you get access back soon enough!

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @claystation!
LGTM.

@codecov

codecovBot commented Sep 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.08%. Comparing base (f137c94) to head (484d81c).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3719 +/- ##
=======================================
Coverage 91.08% 91.08% =======================================
Files 187 187 Lines 16581 16581 =======================================
Hits 15103 15103 Misses 1293 1293 Partials 185 185 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis
gmlewis merged commit 929058e into google:masterSep 22, 2025
7 checks passed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ruleset exempt bypass

2 participants

@claystation@gmlewis