Skip to content

feat: Immutable releases support - #3725

Merged
gmlewis merged 1 commit into
google:masterfrom
scop:feat/immutable-release
Sep 26, 2025
Merged

feat: Immutable releases support#3725
gmlewis merged 1 commit into
google:masterfrom
scop:feat/immutable-release

Conversation

@scop

@scopscop commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

@scopscop mentioned this pull request Sep 23, 2025
@codecov

codecovBot commented Sep 23, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.11%. Comparing base (1b53270) to head (bf4be06).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3725 +/- ##
=======================================
Coverage 91.11% 91.11% =======================================
Files 187 187 Lines 16686 16686 =======================================
Hits 15204 15204 Misses 1295 1295 Partials 187 187 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @scop!
Can you please fix the linter errors, and then we will review the PR?

@gmlewisgmlewis added waiting for reply NeedsReview PR is awaiting a review before merging. labels Sep 23, 2025
@scop

scop commented Sep 24, 2025

Copy link
Copy Markdown
ContributorAuthor

Oops, done.

TarballURL: Ptr("http://tarballurl/"),
Author: &User{Name: Ptr("octocat")},
NodeID: Ptr("nodeid"),
Immutable: Ptr(false),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't set Immutable in CreateRelease, see https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release--parameters

If I understand correctly, @alexandear, this is a case where the documentation does not properly reflect the actual behavior of the system. In #3720 there is a demonstration using curl of receiving the immutable field, so it does indeed appear to exist.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added line is in a section commented as "Fields to be removed". It contains a bunch of other fields that I suppose one cannot set when creating a release, such as the release id, created at, published at, etc. IIUC the purpose of having these set here is to verify that we will not be sending them in create requests even if they're set.

@gmlewisgmlewis removed waiting for reply NeedsReview PR is awaiting a review before merging. labels Sep 26, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @alexandear!
Merging.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @scop and @alexandear!
LGTM.
Merging.

@gmlewis
gmlewis merged commit 138500e into google:masterSep 26, 2025
7 checks passed
@scop
scop deleted the feat/immutable-release branch September 26, 2025 12:39
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Immutable releases support

3 participants

@scop@gmlewis@alexandear