Skip to content

test: Ensure bypass_actors serializes as an empty array when clearing ruleset bypass actors - #3734

Merged
gmlewis merged 1 commit into
google:masterfrom
MathieuSevegny:chore/add-test-clear-ba
Sep 24, 2025
Merged

test: Ensure bypass_actors serializes as an empty array when clearing ruleset bypass actors#3734
gmlewis merged 1 commit into
google:masterfrom
MathieuSevegny:chore/add-test-clear-ba

Conversation

@MathieuSevegny

@MathieuSevegnyMathieuSevegny commented Sep 24, 2025

Copy link
Copy Markdown

As asked in #3727, here's a test to ensure bypass_actors is never serialized as null when clearing bypass actors.

Test is failing prior to the fix and passes with the current implementation.

Validates #3726

@gmlewisgmlewis changed the title test: ensure bypass_actors serializes as an empty array when clearing ruleset bypass actorstest: Ensure bypass_actors serializes as an empty array when clearing ruleset bypass actorsSep 24, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MathieuSevegny!
LGTM.
Merging.

@codecov

codecovBot commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.11%. Comparing base (1b53270) to head (9983167).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3734 +/- ##
=======================================
Coverage 91.11% 91.11% =======================================
Files 187 187 Lines 16686 16686 =======================================
Hits 15204 15204 Misses 1295 1295 Partials 187 187 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis
gmlewis merged commit 4756394 into google:masterSep 24, 2025
7 checks passed
@MathieuSevegny
MathieuSevegny deleted the chore/add-test-clear-ba branch September 24, 2025 14:51
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MathieuSevegny@gmlewis