Skip to content

fix!: Change return type of GetDefaultCodeSecurityConfigurations - #3747

Merged
gmlewis merged 3 commits into
google:masterfrom
ericmort:fix/3744-change-get-default-security-return-type
Oct 2, 2025
Merged

fix!: Change return type of GetDefaultCodeSecurityConfigurations#3747
gmlewis merged 3 commits into
google:masterfrom
ericmort:fix/3744-change-get-default-security-return-type

Conversation

@ericmort

@ericmortericmort commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: GetDefaultCodeSecurityConfigurations now returns CodeSecurityConfigurationWithDefaultForNewRepos instead of CodeSecurityConfiguration.

Modifies the return type of GetDefaultCodeSecurityConfigurations to match the response schema of the API.

Fixes: #3744.

@codecov

codecovBot commented Oct 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.11%. Comparing base (46f1bf2) to head (d4efcfe).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3747 +/- ##
=======================================
Coverage 91.11% 91.11% =======================================
Files 187 187 Lines 16702 16702 =======================================
Hits 15218 15218 Misses 1296 1296 Partials 188 188 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis changed the title fix return type of GetDefaultCodeSecurityConfigurationsfix!: Change return type of GetDefaultCodeSecurityConfigurationsOct 2, 2025
@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Oct 2, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ericmort and @zyfy29!
LGTM.
Merging.

@gmlewis
gmlewis merged commit 83697c8 into google:masterOct 2, 2025
7 checks passed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
…oogle#3747)
BREAKING CHANGE: `GetDefaultCodeSecurityConfigurations` now returns `CodeSecurityConfigurationWithDefaultForNewRepos` instead of `CodeSecurityConfiguration`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetDefaultCodeSecurityConfigurations returns []*CodeSecurityConfiguration but should return []*CodeSecurityConfigurationWithDefaultForNewRepos

3 participants

@ericmort@gmlewis@ericmortebidbax