Uh oh!
There was an error while loading. Please reload this page.
Add custom jsonfieldname linter to ensure Go field name matches JSON tag name - #3757
Conversation
…tag name Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #3757 +/- ##
=======================================
Coverage 91.50% 91.50% =======================================
Files 190 190 Lines 17007 17007 =======================================
Hits 15562 15562 Misses 1257 1257 Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
commented
Oct 6, 2025
@stevehipwell - @alexandear - @zyfy29 - might you have time for a code review? Thank you! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
commented
Oct 17, 2025
Thank you, @alexandear! I believe I've addressed your feedback. |
Uh oh!
There was an error while loading. Please reload this page.
Note that there are many Go field names that do not match the JSON tag names, but changing them all would be a massive breaking API change that is probably unnecessary, and can instead be addressed on a one-by-one basis.
Additionally, one JSON tag had a typo which I've fixed in this PR.