Skip to content

test: Ensure Authorization is not set with empty token - #3790

Merged
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:test/with-auth-token
Oct 24, 2025
Merged

test: Ensure Authorization is not set with empty token#3790
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:test/with-auth-token

Conversation

@alexandear

Copy link
Copy Markdown
Contributor

A test case for #3789.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you, @alexandear!
LGTM.
Merging.

@codecov

codecovBot commented Oct 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (b755d64) to head (a3e8195).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3790 +/- ##
=======================================
Coverage 92.17% 92.17% =======================================
Files 191 191 Lines 13690 13690 =======================================
Hits 12619 12619 Misses 883 883 Partials 188 188 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsorefjsoref left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Sorry as a drive-by person without Google credits to burn, trying to design this was outside scope. I really appreciate that my baseline PR was merged and you wrote a follow up to add tests. (I'm currently smarting because some other company closed a PR of mine to fix a clear regression of theirs because they decided the problem scope was too complicated to let externals work on.)

@gmlewis
gmlewis merged commit ab86053 into google:masterOct 24, 2025
7 checks passed
@alexandear
alexandear deleted the test/with-auth-token branch October 24, 2025 15:55
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandear@jsoref@gmlewis