Skip to content

fix: Org/Enterprise UpdateRepositoryRulesetClearBypassActor sends empty array - #3796

Merged
gmlewis merged 1 commit into
google:masterfrom
dblinkhorn:fix-org-enterprise-bypass-actors
Nov 3, 2025
Merged

fix: Org/Enterprise UpdateRepositoryRulesetClearBypassActor sends empty array#3796
gmlewis merged 1 commit into
google:masterfrom
dblinkhorn:fix-org-enterprise-bypass-actors

Conversation

@dblinkhorn

Copy link
Copy Markdown
Contributor

This PR Fixes the same bug in organization and enterprise rulesets that was fixed for repository rulesets in PR #3727 (issue #3726).

Changes

  • Initialize BypassActors with empty slice instead of nil
  • Add test validation to verify correct JSON payload is sent

Closes#3795.

…ty array
- Initialize BypassActors with empty slice instead of nil
- Ensures JSON payload includes bypass_actors:[] instead of null
- Matches fix from PR google#3727 for repository rulesets
- Adds testBody validation to verify correct JSON payload is sent
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Oct 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (53d0e6a) to head (0df563f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3796 +/- ##
=======================================
Coverage 92.17% 92.17% =======================================
Files 191 191 Lines 13690 13692 +2 =======================================
+ Hits 12619 12621 +2 
Misses 883 883 Partials 188 188 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dblinkhorn!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 30, 2025
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 3, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @alexandear!
Merging.

@gmlewis
gmlewis merged commit e7abb9f into google:masterNov 3, 2025
7 checks passed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Organizations/Enterprise UpdateRepositoryRulesetClearBypassActor sends null instead of empty array

3 participants

@dblinkhorn@gmlewis@alexandear