Skip to content

feat!: Address post-merge enterprise billing cost center review - #3805

Merged
gmlewis merged 3 commits into
google:masterfrom
gjasny:billing-costcenter-fixup
Nov 7, 2025
Merged

feat!: Address post-merge enterprise billing cost center review#3805
gmlewis merged 3 commits into
google:masterfrom
gjasny:billing-costcenter-fixup

Conversation

@gjasny

@gjasnygjasny commented Nov 5, 2025•
edited by gmlewis
Loading

Copy link
Copy Markdown
Contributor

BREAKING CHANGES: Various EnterpriseService structs have been renamed for consistency.

@gjasnygjasny mentioned this pull request Nov 5, 2025
Merged
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 5, 2025
@gmlewis

gmlewis commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator

cc: @alexandear

@codecov

codecovBot commented Nov 5, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (943b801) to head (68990a7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3805 +/- ##
=======================================
Coverage 92.27% 92.27% =======================================
Files 192 192 Lines 13896 13896 =======================================
Hits 12823 12823 Misses 884 884 Partials 189 189

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alexandear
alexandear reviewed Nov 5, 2025
View reviewed changes

@alexandearalexandear left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Suggested a few renamings.

Comment threadgithub/enterprise_billing_cost_centers.go Outdated
Comment threadgithub/enterprise_billing_cost_centers.go Outdated
Comment threadgithub/enterprise_billing_cost_centers.go Outdated
@gjasny

gjasny commented Nov 5, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks. Renamed.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 7, 2025
@gmlewis

gmlewis commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

Thank you, @gjasny, @zyfy29, and @alexandear!
Merging.

@gmlewisgmlewis changed the title feat: Address post-merge enterprise billing cost center reviewfeat!: Address post-merge enterprise billing cost center reviewNov 7, 2025
@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Nov 7, 2025
@gmlewis
gmlewis merged commit 1b0a91c into google:masterNov 7, 2025
7 checks passed
@gmlewisgmlewis mentioned this pull request Nov 8, 2025
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
feat!: Address post-merge enterprise billing cost center review (goog…
459252d
…le#3805)
BREAKING CHANGES: Various `EnterpriseService` structs have been renamed for consistency.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@alexandearalexandearalexandear approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gjasny@gmlewis@alexandear