Skip to content

feat: Add hosted runners URL and network configuration ID to runner group models - #3825

Merged
gmlewis merged 2 commits into
google:masterfrom
austenstone:master
Nov 13, 2025
Merged

feat: Add hosted runners URL and network configuration ID to runner group models#3825
gmlewis merged 2 commits into
google:masterfrom
austenstone:master

Conversation

@austenstone

@austenstoneaustenstone commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Adds missing fields to runner group models based on the GitHub API documentation:

Added to RunnerGroup:

  • HostedRunnersURL - URL for hosted runners in the group
  • NetworkConfigurationID - Identifier for hosted compute network configuration

Added to CreateRunnerGroupRequest:

  • NetworkConfigurationID - Network configuration when creating runner groups

Added to UpdateRunnerGroupRequest:

  • NetworkConfigurationID - Network configuration when updating runner groups (can be null to unset)

All tests updated and passing.

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @austenstone!
Please run step 4 of CONTRIBUTING.md and push the changes to this PR.

@codecov

codecovBot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (025030e) to head (70d5a6a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3825 +/- ##
=======================================
Coverage 92.33% 92.33% =======================================
Files 194 194 Lines 13990 13990 =======================================
Hits 12917 12917 Misses 884 884 Partials 189 189 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @austenstone!
LGTM.
Merging.

@gmlewis
gmlewis merged commit e6f325b into google:masterNov 13, 2025
7 checks passed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@austenstone@gmlewis