Uh oh!
There was an error while loading. Please reload this page.
feat: Add support for Enterprise GitHub App Installation APIs - #3830
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #3830 +/- ##
==========================================
+ Coverage 92.38% 92.41% +0.03%
==========================================
Files 196 197 +1 Lines 14094 14152 +58 ==========================================
+ Hits 13021 13079 +58
Misses 884 884 Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
Uh oh!
There was an error while loading. Please reload this page.
stevehipwell
left a comment
There was a problem hiding this comment.
I've just reviewed the API surface and I think some of the function names need re-working before doing a deeper review.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
@stevehipwell Thanks for the suggestions, I have change the name for both - |
…ppAccessibleRepositories
stevehipwell
left a comment
There was a problem hiding this comment.
I still don't think the API is consistent, how about the following changes to make the API consistent by using an App prefix with all unnecessary padding removed?
ListInstallableAppOrganizations->ListAppInstallableOrganizationsListOrganizationAppAccessibleRepositories->ListAppAccessibleOrganizationRepositoriesListAppOrganizationInstallations->ListAppInstallationsInstallEnterpriseOrganizationApp->InstallAppUninstallEnterpriseOrganizationApp->UninstallApp
Not-Dhananjay-Mishra
commented
Nov 17, 2025
I have implemented the following changes as requested |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Not-Dhananjay-Mishra
commented
Nov 17, 2025
@alexandear Thanks for all suggestions, I made some changes as requested -
|
stevehipwell
left a comment
There was a problem hiding this comment.
My changes have been implemented and I'm happy to approve but I think @alexandear did a more thorough review so his approval would likely carry more weight.
gmlewis
commented
Nov 18, 2025
Thank you, @stevehipwell and @alexandear! |
Uh oh!
There was an error while loading. Please reload this page.
Relates-to: #3829
This PR add support for the following API endpoints -
REST API endpoints for Github App Installation