Skip to content

feat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMUsers - #3839

Merged
gmlewis merged 7 commits into
google:masterfrom
elminster-aom:dev/SCIMUser_list
Nov 25, 2025
Merged

feat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMUsers#3839
gmlewis merged 7 commits into
google:masterfrom
elminster-aom:dev/SCIMUser_list

Conversation

@elminster-aom

@elminster-aomelminster-aom commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: ListProvisionedSCIMGroupsEnterpriseOptions optional fields are now pointers.

Related with #3813

Summary

From REST API endpoints for Enterprise SCIM docs, implements:

Other changes

  • Fix Enterprise.ListProvisionedSCIMGroups Accept header, set it to application/scim+json
  • Correct Enterprise.ListProvisionedSCIMGroups unti test function name

@elminster-aomelminster-aom left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an incoherence about the Accept header. While the document states for all endpoints:

Headers
accept string
Setting to application/vnd.github+json is recommended.

Their example endpoints use different values. For example on GET .../Users: -H "Accept: application/scim+json"

Reported to GitHub support and they confirmed that:

The correct header is Accept: application/scim+json.

Fix here for EnterpriseService.ListProvisionedSCIMGroups

TODO

Fix for SCIMService endpoints too.

@elminster-aom
elminster-aom marked this pull request as ready for review November 19, 2025 08:19
@codecov

codecovBot commented Nov 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.42%. Comparing base (4bdf8fb) to head (db8c98c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3839 +/- ##
=======================================
Coverage 92.41% 92.42% =======================================
Files 197 197 Lines 14152 14167 +15 =======================================
+ Hits 13079 13094 +15 
Misses 884 884 Partials 189 189 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom!
Just a few tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

Comment threadgithub/enterprise_scim.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 19, 2025
@gmlewisgmlewis changed the title Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMUsersfeat!: Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMUsersNov 25, 2025
@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Nov 25, 2025

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @alexandear

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 25, 2025
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @alexandear!
Merging.

@gmlewis
gmlewis merged commit 55ef859 into google:masterNov 25, 2025
7 checks passed
@elminster-aom
elminster-aom deleted the dev/SCIMUser_list branch November 25, 2025 15:59
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
…CIMUsers (google#3839)
BREAKING CHANGE: `ListProvisionedSCIMGroupsEnterpriseOptions` optional fields are now pointers.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@elminster-aom@gmlewis@alexandear