Uh oh!
There was an error while loading. Please reload this page.
chore: Update golangci-lint to v2.7.0 - #3853
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
a21baa5 to
44db530Compare
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell and @alexandear!
LGTM.
Merging.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #3853 +/- ##
=======================================
Coverage 92.46% 92.46% =======================================
Files 199 199 Lines 14240 14240 =======================================
Hits 13167 13167 Misses 884 884 Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
| if before, _, ok := strings.Cut(text, "</a>"); ok { | ||
| newText := before + strings.Join(innerText, "") |
There was a problem hiding this comment.
stringscut may report false positives: golang/go#76687
There was a problem hiding this comment.
It looked correct to me, do you think it's wrong?
There was a problem hiding this comment.
If it breaks next time I use it, I'll revert the changes, so no big deal.
This PR fixes the currently broken
golangci-lintcustom plugin implementation (broken due to the GitHub Actions Git version). It also makes an auto-fix change that otherwise fails the linter.