Skip to content

feat!: Refactor dependabot secrets to pass request by value - #4348

Merged
gmlewis merged 3 commits into
google:masterfrom
stevehipwell:dependabot-secrets-request-by-value
Jul 7, 2026
Merged

feat!: Refactor dependabot secrets to pass request by value#4348
gmlewis merged 3 commits into
google:masterfrom
stevehipwell:dependabot-secrets-request-by-value

Conversation

@stevehipwell

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: DependabotService methods involving secrets have new params and return values.

This PR updates the Dependabot secret update/create functions to use a value parameter (see #3644). This aligns Dependabot secrets with the changes made to actions secrets (#4335) & actions variables (#4346). It also aligns the names of the actions secret and variable request types.

@codecov

codecovBot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.51%. Comparing base (d870966) to head (3b2f53f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #4348 +/- ##
=======================================
Coverage 97.51% 97.51% =======================================
Files 193 193 Lines 19519 19526 +7 =======================================
+ Hits 19033 19040 +7 
Misses 269 269 Partials 217 217 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell
stevehipwellforce-pushed the dependabot-secrets-request-by-value branch from 1de898e to 8b8c923CompareJuly 6, 2026 08:43
@stevehipwell

Copy link
Copy Markdown
ContributorAuthor

@gmlewis rebased this PR to make it mergeable as it hadn't been reviewed yet.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Jul 6, 2026

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @alexandear - @Not-Dhananjay-Mishra

@gmlewis

Copy link
Copy Markdown
Collaborator

@stevehipwell - please resolve the conflicts so that we may proceed with this PR.

…s-request-by-value
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell

Copy link
Copy Markdown
ContributorAuthor

@gmlewis that should be good now.

@stevehipwell

Copy link
Copy Markdown
ContributorAuthor

@gmlewis shouldn't this have been merged before the v89 release was cut given that it was part of a series of changes? RE the TF provider request, speaking as a maintainer there was no rush for the PR where a release was requested. I'd have added this as a comment if I'd thought that I'd block this PR.

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis shouldn't this have been merged before the v89 release was cut given that it was part of a series of changes? RE the TF provider request, speaking as a maintainer there was no rush for the PR where a release was requested. I'd have added this as a comment if I'd thought that I'd block this PR.

I guess I didn't fully realize the situation over at terraform.

It had been over a month since the last release and I was being asked to cut one, so I did.

I'm sorry about that, @stevehipwell.

We can cut a new one when this series of PRs is completed.

@gmlewis

Copy link
Copy Markdown
Collaborator

@stevehipwell - if you want these PRs moved along faster, feel free to bring in coworkers or other terraform maintainers to move these along.

@stevehipwell

Copy link
Copy Markdown
ContributorAuthor

@stevehipwell - if you want these PRs moved along faster, feel free to bring in coworkers or other terraform maintainers to move these along.

@gmlewis I wish it was that easy. I'll see if I can persuade someone from the TF side to come and help.

@stevehipwell

Copy link
Copy Markdown
ContributorAuthor

@alexandear@Not-Dhananjay-Mishra do either of you have time to give this a quick review?

Comment threadgithub/dependabot_secrets.go
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 7, 2026
@gmlewis
gmlewis merged commit 90a1849 into google:masterJul 7, 2026
15 checks passed
@stevehipwell
stevehipwell deleted the dependabot-secrets-request-by-value branch July 7, 2026 17:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stevehipwell@gmlewis@alexandear