Skip to content

fix: Enable submitting empty allowlist for actions permissions patterns - #4371

Merged
gmlewis merged 4 commits into
google:masterfrom
F-Secure-web:enable-empty-allowlist-actions-permissions
Jul 8, 2026
Merged

fix: Enable submitting empty allowlist for actions permissions patterns#4371
gmlewis merged 4 commits into
google:masterfrom
F-Secure-web:enable-empty-allowlist-actions-permissions

Conversation

@deiga

@deigadeiga commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Resolves#4359

This PR changes PatternsAllowed to use omitzero instead of omitempty. That enables submitting an empty List to the API and thus override any currently set allowlisted patterns.

deiga added 2 commits July 7, 2026 22:17
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
deiga marked this pull request as draft July 7, 2026 19:37
@deiga
deiga marked this pull request as ready for review July 7, 2026 19:37
@deigadeiga changed the title enable empty allowlist actions permissionsEnable submitting an empty allowlist for actions permissions patternsJul 7, 2026
@gmlewisgmlewis changed the title Enable submitting an empty allowlist for actions permissions patternsfix: Enable submitting empty allowlist for actions permissions patternsJul 7, 2026
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 7, 2026
@codecov

codecovBot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.51%. Comparing base (90a1849) to head (7283a32).

Additional details and impacted files
@@ Coverage Diff @@## master #4371 +/- ##
=======================================
Coverage 97.51% 97.51% =======================================
Files 193 193 Lines 19526 19526 =======================================
Hits 19040 19040 Misses 269 269 Partials 217 217 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @deiga!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @Not-Dhananjay-Mishra

Comment threadgithub/actions_permissions_orgs.go Outdated

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Comment threadgithub/actions_permissions_orgs.go Outdated
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga
deiga requested a review from gmlewisJuly 8, 2026 18:27
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: GitHub Actions Permissions do not allow emptying a once-set allowlist

4 participants

@deiga@alexandear@stevehipwell@gmlewis