Uh oh!
There was an error while loading. Please reload this page.
feat: Add search_type support to issue search - #4414
Merged
Conversation
kelsey-myers
marked this pull request as ready for review
July 27, 2026 20:57
search_type support to issue searchCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #4414 +/- ##
=======================================
Coverage 97.54% 97.54% =======================================
Files 194 194 Lines 19765 19765 =======================================
Hits 19279 19279 Misses 268 268 Partials 218 218 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Jul 27, 2026
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @kelsey-myers!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#4415
The search issues and pull requests endpoint supports a
search_typequery parameter (semanticorhybrid, defaulting to lexical), and returns the type that actually ran in the response body. Neither is currently exposed, soSearch.Issuescan only do lexical search, and callers can't tell when the API has fallen back to lexical for an ineligible query.Adds
SearchTypetoSearchOptions(mirroringAdvancedSearch) and toIssuesSearchResult.I'm updating the GitHub MCP server's
search_issuestool to support semantic search, and we'd like to use these rather than wrapping the HTTP transport to rewrite the query string and re-parse the response body.