Skip to content

refactor!: Rename UsersService.Edit to Update, introduce UserUpdateRequest, and pass request by value - #4433

Merged
gmlewis merged 8 commits into
google:masterfrom
ManavSharma142:master
Aug 6, 2026
Merged

refactor!: Rename UsersService.Edit to Update, introduce UserUpdateRequest, and pass request by value#4433
gmlewis merged 8 commits into
google:masterfrom
ManavSharma142:master

Conversation

@ManavSharma142

@ManavSharma142ManavSharma142 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: UsersService.Edit is now Update and uses a new UserUpdateRequest body value.

Relates to: #3644.

Rename UsersService.Edit to Update for consistency with GitHub API naming.
Introduce a dedicated UserUpdateRequest type containing only fields accepted by the update endpoint, and pass it by value instead of a pointer.

@ManavSharma142ManavSharma142 changed the title refactor!: rename UsersService.Edit to Update, introduce UserUpdateRequest, and pass request by valuerefactor!: Rename UsersService.Edit to Update, introduce UserUpdateRequest, and pass request by valueAug 6, 2026
@gmlewisgmlewis changed the title refactor!: Rename UsersService.Edit to Update, introduce UserUpdateRequest, and pass request by valuerefactor!: Rename UsersService.Edit to Update, introduce UserUpdateRequest, and pass request by valueAug 6, 2026
@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Aug 6, 2026
@gmlewis

Copy link
Copy Markdown
Collaborator

@ManavSharma142 - I edited the description to add two important lines.
Also, in the description you should cc: @JamBalaya56562 and @jvm986.

Now, you need to run tests locally following the guidance in CONTRIBUTING.md, especially step 4, and push the changes to this PR while trying to avoid force pushing when possible.

@codecov

codecovBot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.55%. Comparing base (4a79475) to head (d69b8f1).

Additional details and impacted files
@@ Coverage Diff @@## master #4433 +/- ##
=======================================
Coverage 97.55% 97.55% =======================================
Files 194 194 Lines 19892 19892 =======================================
Hits 19406 19406 Misses 268 268 Partials 218 218 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ManavSharma142!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @Not-Dhananjay-Mishra

@Not-Dhananjay-MishraNot-Dhananjay-Mishra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 6, 2026
@gmlewis
gmlewis merged commit 65628e2 into google:masterAug 6, 2026
15 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ManavSharma142@gmlewis@Not-Dhananjay-Mishra