Uh oh!
There was an error while loading. Please reload this page.
refactor!: Rename UsersService.Edit to Update, introduce UserUpdateRequest, and pass request by value - #4433
Conversation
UsersService.Edit to Update, introduce UserUpdateRequest, and pass request by valuegmlewis
commented
Aug 6, 2026
@ManavSharma142 - I edited the description to add two important lines. Now, you need to run tests locally following the guidance in CONTRIBUTING.md, especially step 4, and push the changes to this PR while trying to avoid force pushing when possible. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #4433 +/- ##
=======================================
Coverage 97.55% 97.55% =======================================
Files 194 194 Lines 19892 19892 =======================================
Hits 19406 19406 Misses 268 268 Partials 218 218 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @ManavSharma142!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
BREAKING CHANGE:
UsersService.Editis nowUpdateand uses a newUserUpdateRequestbody value.Relates to: #3644.
Rename UsersService.Edit to Update for consistency with GitHub API naming.
Introduce a dedicated UserUpdateRequest type containing only fields accepted by the update endpoint, and pass it by value instead of a pointer.