Add all common parameters to context definition and make gl.getParameter support. by Molay · Pull Request #66 · google/node-gles

Molay · 2020-03-03T06:03:52Z

feat(webgl_rendering_context): Add all common parameters to context definition, make method gl.getParameter support int32array and float32array return value.
fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes.
feat(webgl_extensions): Add WEBGL_draw_buffers extension.
feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

This change is

…efinition, make method gl.getParameter support int32array and float32array return value. fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes. feat(webgl_extensions): Add WEBGL_draw_buffers extension. feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

googlebot · 2020-03-03T06:03:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Molay · 2020-03-03T06:05:20Z

@googlebot I signed it!

googlebot · 2020-03-03T06:05:22Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger

Sorry I was out on leave and missed this!

Just a few comments, thank you for this detailed PR!

nkreeger · 2020-04-16T17:39:09Z

+ const { name, type, subType, length, /*nullable,*/ extension } = parameterDefinition;
+ let ptarget: any = gl, pname: GLenum;
+ const result = new VerifyResult();
+ // if (name === 'DRAW_BUFFER?_WEBGL') return verifyDrawBuffersWebgl(gl, parameterDefinition);


Cleanup here?

nkreeger · 2020-04-16T17:39:25Z

+ value = gl.getParameter(pname);
+ }
+ catch (error) {
+ // return result.setObject(error);


Ditto here.

nkreeger · 2020-04-16T17:40:19Z

+ let numPassed = 0;
+ parameterDefinitions.forEach((parameterDefinition, index) => {
+ const result = verifyParameterDefinition(gl, parameterDefinition);
+ result.passed ? process.stdout.write(`\u001b[92m`) : process.stdout.write(`\u001b[91m`);


Looks like some formatting problems here.

Molay · 2020-03-03T06:03:52Z

feat(webgl_rendering_context): Add all common parameters to context definition, make method gl.getParameter support int32array and float32array return value.
fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes.
feat(webgl_extensions): Add WEBGL_draw_buffers extension.
feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

This change is

…efinition, make method gl.getParameter support int32array and float32array return value. fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes. feat(webgl_extensions): Add WEBGL_draw_buffers extension. feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

googlebot · 2020-03-03T06:03:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Molay · 2020-03-03T06:05:20Z

@googlebot I signed it!

googlebot · 2020-03-03T06:05:22Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger

Sorry I was out on leave and missed this!

Just a few comments, thank you for this detailed PR!

nkreeger · 2020-04-16T17:39:09Z

+ const { name, type, subType, length, /*nullable,*/ extension } = parameterDefinition;
+ let ptarget: any = gl, pname: GLenum;
+ const result = new VerifyResult();
+ // if (name === 'DRAW_BUFFER?_WEBGL') return verifyDrawBuffersWebgl(gl, parameterDefinition);


Cleanup here?

nkreeger · 2020-04-16T17:39:25Z

+ value = gl.getParameter(pname);
+ }
+ catch (error) {
+ // return result.setObject(error);


Ditto here.

nkreeger · 2020-04-16T17:40:19Z

+ let numPassed = 0;
+ parameterDefinitions.forEach((parameterDefinition, index) => {
+ const result = verifyParameterDefinition(gl, parameterDefinition);
+ result.passed ? process.stdout.write(`\u001b[92m`) : process.stdout.write(`\u001b[91m`);


Looks like some formatting problems here.

Molay · 2020-03-03T06:03:52Z

feat(webgl_rendering_context): Add all common parameters to context definition, make method gl.getParameter support int32array and float32array return value.
fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes.
feat(webgl_extensions): Add WEBGL_draw_buffers extension.
feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

This change is

…efinition, make method gl.getParameter support int32array and float32array return value. fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes. feat(webgl_extensions): Add WEBGL_draw_buffers extension. feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

googlebot · 2020-03-03T06:03:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Molay · 2020-03-03T06:05:20Z

@googlebot I signed it!

googlebot · 2020-03-03T06:05:22Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger

Sorry I was out on leave and missed this!

Just a few comments, thank you for this detailed PR!

nkreeger · 2020-04-16T17:39:09Z

+ const { name, type, subType, length, /*nullable,*/ extension } = parameterDefinition;
+ let ptarget: any = gl, pname: GLenum;
+ const result = new VerifyResult();
+ // if (name === 'DRAW_BUFFER?_WEBGL') return verifyDrawBuffersWebgl(gl, parameterDefinition);


Cleanup here?

nkreeger · 2020-04-16T17:39:25Z

+ value = gl.getParameter(pname);
+ }
+ catch (error) {
+ // return result.setObject(error);


Ditto here.

nkreeger · 2020-04-16T17:40:19Z

+ let numPassed = 0;
+ parameterDefinitions.forEach((parameterDefinition, index) => {
+ const result = verifyParameterDefinition(gl, parameterDefinition);
+ result.passed ? process.stdout.write(`\u001b[92m`) : process.stdout.write(`\u001b[91m`);


Looks like some formatting problems here.

Molay · 2020-03-03T06:03:52Z

feat(webgl_rendering_context): Add all common parameters to context definition, make method gl.getParameter support int32array and float32array return value.
fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes.
feat(webgl_extensions): Add WEBGL_draw_buffers extension.
feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

This change is

…efinition, make method gl.getParameter support int32array and float32array return value. fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes. feat(webgl_extensions): Add WEBGL_draw_buffers extension. feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

googlebot · 2020-03-03T06:03:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Molay · 2020-03-03T06:05:20Z

@googlebot I signed it!

googlebot · 2020-03-03T06:05:22Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger

Sorry I was out on leave and missed this!

Just a few comments, thank you for this detailed PR!

nkreeger · 2020-04-16T17:39:09Z

+ const { name, type, subType, length, /*nullable,*/ extension } = parameterDefinition;
+ let ptarget: any = gl, pname: GLenum;
+ const result = new VerifyResult();
+ // if (name === 'DRAW_BUFFER?_WEBGL') return verifyDrawBuffersWebgl(gl, parameterDefinition);


Cleanup here?

nkreeger · 2020-04-16T17:39:25Z

+ value = gl.getParameter(pname);
+ }
+ catch (error) {
+ // return result.setObject(error);


Ditto here.

nkreeger · 2020-04-16T17:40:19Z

+ let numPassed = 0;
+ parameterDefinitions.forEach((parameterDefinition, index) => {
+ const result = verifyParameterDefinition(gl, parameterDefinition);
+ result.passed ? process.stdout.write(`\u001b[92m`) : process.stdout.write(`\u001b[91m`);


Looks like some formatting problems here.

Molay · 2020-03-03T06:03:52Z

feat(webgl_rendering_context): Add all common parameters to context definition, make method gl.getParameter support int32array and float32array return value.
fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes.
feat(webgl_extensions): Add WEBGL_draw_buffers extension.
feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

This change is

…efinition, make method gl.getParameter support int32array and float32array return value. fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes. feat(webgl_extensions): Add WEBGL_draw_buffers extension. feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

googlebot · 2020-03-03T06:03:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Molay · 2020-03-03T06:05:20Z

@googlebot I signed it!

googlebot · 2020-03-03T06:05:22Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger

Sorry I was out on leave and missed this!

Just a few comments, thank you for this detailed PR!

nkreeger · 2020-04-16T17:39:09Z

+ const { name, type, subType, length, /*nullable,*/ extension } = parameterDefinition;
+ let ptarget: any = gl, pname: GLenum;
+ const result = new VerifyResult();
+ // if (name === 'DRAW_BUFFER?_WEBGL') return verifyDrawBuffersWebgl(gl, parameterDefinition);


Cleanup here?

nkreeger · 2020-04-16T17:39:25Z

+ value = gl.getParameter(pname);
+ }
+ catch (error) {
+ // return result.setObject(error);


Ditto here.

nkreeger · 2020-04-16T17:40:19Z

+ let numPassed = 0;
+ parameterDefinitions.forEach((parameterDefinition, index) => {
+ const result = verifyParameterDefinition(gl, parameterDefinition);
+ result.passed ? process.stdout.write(`\u001b[92m`) : process.stdout.write(`\u001b[91m`);


Looks like some formatting problems here.

Molay · 2020-03-03T06:03:52Z

feat(webgl_rendering_context): Add all common parameters to context definition, make method gl.getParameter support int32array and float32array return value.
fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes.
feat(webgl_extensions): Add WEBGL_draw_buffers extension.
feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

This change is

…efinition, make method gl.getParameter support int32array and float32array return value. fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes. feat(webgl_extensions): Add WEBGL_draw_buffers extension. feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

googlebot · 2020-03-03T06:03:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Molay · 2020-03-03T06:05:20Z

@googlebot I signed it!

googlebot · 2020-03-03T06:05:22Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger

Sorry I was out on leave and missed this!

Just a few comments, thank you for this detailed PR!

nkreeger · 2020-04-16T17:39:09Z

+ const { name, type, subType, length, /*nullable,*/ extension } = parameterDefinition;
+ let ptarget: any = gl, pname: GLenum;
+ const result = new VerifyResult();
+ // if (name === 'DRAW_BUFFER?_WEBGL') return verifyDrawBuffersWebgl(gl, parameterDefinition);


Cleanup here?

nkreeger · 2020-04-16T17:39:25Z

+ value = gl.getParameter(pname);
+ }
+ catch (error) {
+ // return result.setObject(error);


Ditto here.

nkreeger · 2020-04-16T17:40:19Z

+ let numPassed = 0;
+ parameterDefinitions.forEach((parameterDefinition, index) => {
+ const result = verifyParameterDefinition(gl, parameterDefinition);
+ result.passed ? process.stdout.write(`\u001b[92m`) : process.stdout.write(`\u001b[91m`);


Looks like some formatting problems here.

Molay · 2020-03-03T06:03:52Z

feat(webgl_rendering_context): Add all common parameters to context definition, make method gl.getParameter support int32array and float32array return value.
fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes.
feat(webgl_extensions): Add WEBGL_draw_buffers extension.
feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

This change is

…efinition, make method gl.getParameter support int32array and float32array return value. fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes. feat(webgl_extensions): Add WEBGL_draw_buffers extension. feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

googlebot · 2020-03-03T06:03:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Molay · 2020-03-03T06:05:20Z

@googlebot I signed it!

googlebot · 2020-03-03T06:05:22Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger

Sorry I was out on leave and missed this!

Just a few comments, thank you for this detailed PR!

nkreeger · 2020-04-16T17:39:09Z

+ const { name, type, subType, length, /*nullable,*/ extension } = parameterDefinition;
+ let ptarget: any = gl, pname: GLenum;
+ const result = new VerifyResult();
+ // if (name === 'DRAW_BUFFER?_WEBGL') return verifyDrawBuffersWebgl(gl, parameterDefinition);


Cleanup here?

nkreeger · 2020-04-16T17:39:25Z

+ value = gl.getParameter(pname);
+ }
+ catch (error) {
+ // return result.setObject(error);


Ditto here.

nkreeger · 2020-04-16T17:40:19Z

+ let numPassed = 0;
+ parameterDefinitions.forEach((parameterDefinition, index) => {
+ const result = verifyParameterDefinition(gl, parameterDefinition);
+ result.passed ? process.stdout.write(`\u001b[92m`) : process.stdout.write(`\u001b[91m`);


Looks like some formatting problems here.

Molay · 2020-03-03T06:03:52Z

feat(webgl_rendering_context): Add all common parameters to context definition, make method gl.getParameter support int32array and float32array return value.
fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes.
feat(webgl_extensions): Add WEBGL_draw_buffers extension.
feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

This change is

…efinition, make method gl.getParameter support int32array and float32array return value. fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes. feat(webgl_extensions): Add WEBGL_draw_buffers extension. feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).

googlebot · 2020-03-03T06:03:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Molay · 2020-03-03T06:05:20Z

@googlebot I signed it!

googlebot · 2020-03-03T06:05:22Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger

Sorry I was out on leave and missed this!

Just a few comments, thank you for this detailed PR!

nkreeger · 2020-04-16T17:39:09Z

+ const { name, type, subType, length, /*nullable,*/ extension } = parameterDefinition;
+ let ptarget: any = gl, pname: GLenum;
+ const result = new VerifyResult();
+ // if (name === 'DRAW_BUFFER?_WEBGL') return verifyDrawBuffersWebgl(gl, parameterDefinition);


Cleanup here?

nkreeger · 2020-04-16T17:39:25Z

+ value = gl.getParameter(pname);
+ }
+ catch (error) {
+ // return result.setObject(error);


Ditto here.

nkreeger · 2020-04-16T17:40:19Z

+ let numPassed = 0;
+ parameterDefinitions.forEach((parameterDefinition, index) => {
+ const result = verifyParameterDefinition(gl, parameterDefinition);
+ result.passed ? process.stdout.write(`\u001b[92m`) : process.stdout.write(`\u001b[91m`);


Looks like some formatting problems here.

feat(webgl_rendering_context): Optimize gl.getParameter method to sup…
f8e801f
…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger reviewed Apr 16, 2020
View reviewed changes

feat(webgl_rendering_context): Optimize gl.getParameter method to sup…
f8e801f
…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger reviewed Apr 16, 2020
View reviewed changes

feat(webgl_rendering_context): Optimize gl.getParameter method to sup…
f8e801f
…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger reviewed Apr 16, 2020
View reviewed changes

feat(webgl_rendering_context): Optimize gl.getParameter method to sup…
f8e801f
…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger reviewed Apr 16, 2020
View reviewed changes

feat(webgl_rendering_context): Optimize gl.getParameter method to sup…
f8e801f
…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger reviewed Apr 16, 2020
View reviewed changes

feat(webgl_rendering_context): Optimize gl.getParameter method to sup…
f8e801f
…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger reviewed Apr 16, 2020
View reviewed changes

feat(webgl_rendering_context): Optimize gl.getParameter method to sup…
f8e801f
…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger reviewed Apr 16, 2020
View reviewed changes

feat(webgl_rendering_context): Optimize gl.getParameter method to sup…
f8e801f
…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).

nkreeger reviewed Apr 16, 2020
View reviewed changes

Uh oh!

Conversation

Molay commented Mar 3, 2020• edited by nkreeger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Mar 3, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Molay commented Mar 3, 2020

Uh oh!

googlebot commented Mar 3, 2020

Uh oh!

nkreeger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Molay commented Mar 3, 2020• edited by nkreeger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Mar 3, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Molay commented Mar 3, 2020

Uh oh!

googlebot commented Mar 3, 2020

Uh oh!

nkreeger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Molay commented Mar 3, 2020• edited by nkreeger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Mar 3, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Molay commented Mar 3, 2020

Uh oh!

googlebot commented Mar 3, 2020

Uh oh!

nkreeger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Molay commented Mar 3, 2020•
edited by nkreeger
Loading

Molay commented Mar 3, 2020•
edited by nkreeger
Loading

Molay commented Mar 3, 2020•
edited by nkreeger
Loading

Molay commented Mar 3, 2020•
edited by nkreeger
Loading