Add travis and appveyor for prebuilding binaries by Prior99 · Pull Request #72 · google/node-gles

Prior99 · 2020-07-08T17:54:10Z

This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac.
The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.

I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.

This change is

googlebot · 2020-07-08T17:54:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T18:02:25Z

@googlebot I signed it!

googlebot · 2020-07-08T18:02:28Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T20:47:46Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Url in this line needs to be adjusted to this repository.

Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

nkreeger · 2020-07-13T13:46:47Z

This is really great - thank you! Apologies for the lag on the review.

I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy.

nkreeger · 2020-07-13T13:40:01Z

+before_install:
+ - npm install -g yarn
+ - if [ $TRAVIS_OS_NAME == "linux" ]; then
+ export CC="gcc-7";


Can you just specify "gcc"? These should be symlink'd on linux.

nkreeger · 2020-07-13T13:43:20Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

Prior99 · 2020-07-08T17:54:10Z

This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac.
The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.

I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.

This change is

googlebot · 2020-07-08T17:54:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T18:02:25Z

@googlebot I signed it!

googlebot · 2020-07-08T18:02:28Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T20:47:46Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Url in this line needs to be adjusted to this repository.

Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

nkreeger · 2020-07-13T13:46:47Z

This is really great - thank you! Apologies for the lag on the review.

I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy.

nkreeger · 2020-07-13T13:40:01Z

+before_install:
+ - npm install -g yarn
+ - if [ $TRAVIS_OS_NAME == "linux" ]; then
+ export CC="gcc-7";


Can you just specify "gcc"? These should be symlink'd on linux.

nkreeger · 2020-07-13T13:43:20Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

Prior99 · 2020-07-08T17:54:10Z

This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac.
The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.

I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.

This change is

googlebot · 2020-07-08T17:54:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T18:02:25Z

@googlebot I signed it!

googlebot · 2020-07-08T18:02:28Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T20:47:46Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Url in this line needs to be adjusted to this repository.

Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

nkreeger · 2020-07-13T13:46:47Z

This is really great - thank you! Apologies for the lag on the review.

I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy.

nkreeger · 2020-07-13T13:40:01Z

+before_install:
+ - npm install -g yarn
+ - if [ $TRAVIS_OS_NAME == "linux" ]; then
+ export CC="gcc-7";


Can you just specify "gcc"? These should be symlink'd on linux.

nkreeger · 2020-07-13T13:43:20Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

Prior99 · 2020-07-08T17:54:10Z

This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac.
The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.

I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.

This change is

googlebot · 2020-07-08T17:54:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T18:02:25Z

@googlebot I signed it!

googlebot · 2020-07-08T18:02:28Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T20:47:46Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Url in this line needs to be adjusted to this repository.

Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

nkreeger · 2020-07-13T13:46:47Z

This is really great - thank you! Apologies for the lag on the review.

I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy.

nkreeger · 2020-07-13T13:40:01Z

+before_install:
+ - npm install -g yarn
+ - if [ $TRAVIS_OS_NAME == "linux" ]; then
+ export CC="gcc-7";


Can you just specify "gcc"? These should be symlink'd on linux.

nkreeger · 2020-07-13T13:43:20Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

Prior99 · 2020-07-08T17:54:10Z

This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac.
The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.

I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.

This change is

googlebot · 2020-07-08T17:54:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T18:02:25Z

@googlebot I signed it!

googlebot · 2020-07-08T18:02:28Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T20:47:46Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Url in this line needs to be adjusted to this repository.

Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

nkreeger · 2020-07-13T13:46:47Z

This is really great - thank you! Apologies for the lag on the review.

I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy.

nkreeger · 2020-07-13T13:40:01Z

+before_install:
+ - npm install -g yarn
+ - if [ $TRAVIS_OS_NAME == "linux" ]; then
+ export CC="gcc-7";


Can you just specify "gcc"? These should be symlink'd on linux.

nkreeger · 2020-07-13T13:43:20Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

Prior99 · 2020-07-08T17:54:10Z

This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac.
The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.

I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.

This change is

googlebot · 2020-07-08T17:54:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T18:02:25Z

@googlebot I signed it!

googlebot · 2020-07-08T18:02:28Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T20:47:46Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Url in this line needs to be adjusted to this repository.

Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

nkreeger · 2020-07-13T13:46:47Z

This is really great - thank you! Apologies for the lag on the review.

I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy.

nkreeger · 2020-07-13T13:40:01Z

+before_install:
+ - npm install -g yarn
+ - if [ $TRAVIS_OS_NAME == "linux" ]; then
+ export CC="gcc-7";


Can you just specify "gcc"? These should be symlink'd on linux.

nkreeger · 2020-07-13T13:43:20Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

Prior99 · 2020-07-08T17:54:10Z

This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac.
The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.

I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.

This change is

googlebot · 2020-07-08T17:54:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T18:02:25Z

@googlebot I signed it!

googlebot · 2020-07-08T18:02:28Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T20:47:46Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Url in this line needs to be adjusted to this repository.

Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

nkreeger · 2020-07-13T13:46:47Z

This is really great - thank you! Apologies for the lag on the review.

I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy.

nkreeger · 2020-07-13T13:40:01Z

+before_install:
+ - npm install -g yarn
+ - if [ $TRAVIS_OS_NAME == "linux" ]; then
+ export CC="gcc-7";


Can you just specify "gcc"? These should be symlink'd on linux.

nkreeger · 2020-07-13T13:43:20Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

Prior99 · 2020-07-08T17:54:10Z

This adds prebuilt binaries for the last 4 node versions on 64-bit Windows, Linux and Mac.
The binaries are built on travis and appveyor, the maintainers of this repository would need to enable both for this repository and generate an oauth token, adding them to into the corresponding configurations.

I also preliminarily published this on https://www.npmjs.com/package/node-gles-prebuilt until this is merged.

This change is

googlebot · 2020-07-08T17:54:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T18:02:25Z

@googlebot I signed it!

googlebot · 2020-07-08T18:02:28Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Prior99 · 2020-07-08T20:47:46Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Url in this line needs to be adjusted to this repository.

Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

nkreeger · 2020-07-13T13:46:47Z

This is really great - thank you! Apologies for the lag on the review.

I know that building stuff on Node-gyp isn't always great and I was hoping to get to pre-built binaries at some point. Do you mind adding some documentation on how to pre-build binaries and upload them? I'd love for this to be community supported. As for storage, I'll have to look into what I can do on my end. If it's something easy as stashing on github I think we can do that pretty easy.

nkreeger · 2020-07-13T13:40:01Z

+before_install:
+ - npm install -g yarn
+ - if [ $TRAVIS_OS_NAME == "linux" ]; then
+ export CC="gcc-7";


Can you just specify "gcc"? These should be symlink'd on linux.

nkreeger · 2020-07-13T13:43:20Z

+// Get the version of the library;
+const pkg = require(path.resolve(__dirname, "..", "package.json"));
+const packageVersion = pkg.version;
+const baseUrl = process.env["NODE_GLES_BINARY_URL"] || process.env["npm_config_node_gles_binary_url"] || "https://github.com/Prior99/node-gles/releases/download";


Are you hosting angle builds here? I wish I had more time to manage these, but I'm pretty busy with other projects and don't have the time to manage these builds.
Do you mind adding some documentation where these need to be uploaded? If it's easy for them to be uploaded maybe this is something that can be managed here.

Add travis and appveyor for prebuilding binaries
f32f8f2

Prior99 commented Jul 8, 2020
View reviewed changes

Remove accidentially commited file
0f4b71c

nkreeger suggested changes Jul 13, 2020
View reviewed changes

Add travis and appveyor for prebuilding binaries
f32f8f2

Prior99 commented Jul 8, 2020
View reviewed changes

Remove accidentially commited file
0f4b71c

nkreeger suggested changes Jul 13, 2020
View reviewed changes

Add travis and appveyor for prebuilding binaries
f32f8f2

Prior99 commented Jul 8, 2020
View reviewed changes

Remove accidentially commited file
0f4b71c

nkreeger suggested changes Jul 13, 2020
View reviewed changes

Add travis and appveyor for prebuilding binaries
f32f8f2

Prior99 commented Jul 8, 2020
View reviewed changes

Remove accidentially commited file
0f4b71c

nkreeger suggested changes Jul 13, 2020
View reviewed changes

Add travis and appveyor for prebuilding binaries
f32f8f2

Prior99 commented Jul 8, 2020
View reviewed changes

Remove accidentially commited file
0f4b71c

nkreeger suggested changes Jul 13, 2020
View reviewed changes

Add travis and appveyor for prebuilding binaries
f32f8f2

Prior99 commented Jul 8, 2020
View reviewed changes

Remove accidentially commited file
0f4b71c

nkreeger suggested changes Jul 13, 2020
View reviewed changes

Add travis and appveyor for prebuilding binaries
f32f8f2

Prior99 commented Jul 8, 2020
View reviewed changes

Remove accidentially commited file
0f4b71c

nkreeger suggested changes Jul 13, 2020
View reviewed changes

Add travis and appveyor for prebuilding binaries
f32f8f2

Prior99 commented Jul 8, 2020
View reviewed changes

Remove accidentially commited file
0f4b71c

nkreeger suggested changes Jul 13, 2020
View reviewed changes

Uh oh!

Conversation

Prior99 commented Jul 8, 2020• edited by nkreeger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jul 8, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Prior99 commented Jul 8, 2020

Uh oh!

googlebot commented Jul 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nkreeger commented Jul 13, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Prior99 commented Jul 8, 2020• edited by nkreeger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jul 8, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Prior99 commented Jul 8, 2020

Uh oh!

googlebot commented Jul 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nkreeger commented Jul 13, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Prior99 commented Jul 8, 2020• edited by nkreeger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jul 8, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Prior99 commented Jul 8, 2020

Uh oh!

googlebot commented Jul 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Prior99 commented Jul 8, 2020•
edited by nkreeger
Loading

Prior99 commented Jul 8, 2020•
edited by nkreeger
Loading

Prior99 commented Jul 8, 2020•
edited by nkreeger
Loading

Prior99 commented Jul 8, 2020•
edited by nkreeger
Loading