Uh oh!
There was an error while loading. Please reload this page.
fix(importer): close REST response body on HTTP error - #5987
Merged
michaelkedar merged 3 commits intoSep 8, 2026
Conversation
michaelkedar
commented
Sep 8, 2026
Member
/gcbrun |
michaelkedar
left a comment
Member
There was a problem hiding this comment.
Thanks, happy to merge if you could fix the lint error
michaelkedar
commented
Sep 8, 2026
Member
/gcbrun |
michaelkedar
approved these changes
Sep 8, 2026
Uh oh!
There was an error while loading. Please reload this page.
keeltrace
commented
Sep 8, 2026
ContributorAuthor
Ty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Close the REST source response body before returning an HTTP status error from
restSourceRecord.Open.Fixes#5985
Details
Openreturnsresp.Bodyto callers on success, but previously returned early on 4xx/5xx responses without closing it. This closes the body on the error path and adds a regression test using a trackingReadCloser.Testing
go test -v ./internal/importer -run 'TestRestSourceRecord_Open'go test ./internal/importergit diff --checkAI-assisted contribution: I used an AI coding agent during investigation and implementation. I reviewed the final diff and ran the verification listed above. I am responsible for the submitted change and follow-up.