Uh oh!
There was an error while loading. Please reload this page.
Python 2.6 compatibility. - #2
Conversation
seanfisk
commented
Jan 7, 2014
Is this still being maintained? I really like this library and would like to contribute, but it's hard to do that with this PR still out. |
huan
commented
Mar 21, 2020
Hello @seanfisk , Do you still want to add this support to the pinject? If so, please merge the latest code from the master branch, and make the CI green, then we will be able to merge it. If not, then let's close this PR gracefully. Thank you very much. |
My sense is that Py26 should no longer be a target given that Python 2 died on 1/1/2020 (15 months ago). |
huan
commented
Mar 23, 2021
Agreed with @cclauss, let's prepare to close this PR. If there's anyone wants to keep this PR, please add your reason in the comments before May 1, 2021. If there's no one wants to keep this PR after May 1, then we will close it. |
These changes should provide Python 2.6 compatibility. I still have two failing tests, but they are failing under 2.7 as well. I'll address those in a later pull request.
With the
unittest2change, I committed a file calledrequirements-dev.txt. You can run this to installunittest2by runningpip install -r requirements-dev.txt.I also plan to apply my Python project template in a later pull request. This should make porting to 3.3 much easier. The project template uses
pytestso I will consider porting the tests topytestwhen I am working on that PR.