Skip to content

chore: update nodejs tested versions to active releases (14, 16, 18, 19) - #229

Merged
aabmass merged 1 commit into
google:mainfrom
aabmass:fix-node-versions
Oct 24, 2022
Merged

chore: update nodejs tested versions to active releases (14, 16, 18, 19)#229
aabmass merged 1 commit into
google:mainfrom
aabmass:fix-node-versions

Conversation

@aabmass

@aabmassaabmass commented Oct 21, 2022

Copy link
Copy Markdown
Member

Had to upgrade nan to the latest version which has the fix for nodejs/nan#942. Related to #170 but still no pre-built binaries for node18+.

@aabmass
aabmass requested a review from punyaOctober 22, 2022 17:09
@aabmass
aabmass marked this pull request as ready for review October 22, 2022 17:10
@aabmass
aabmassforce-pushed the fix-node-versions branch 2 times, most recently from 5ee8cb3 to 4a171b1CompareOctober 22, 2022 19:56

@punyapunya left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽

@aabmass
aabmass merged commit 08d7eff into google:mainOct 24, 2022
@aabmass
aabmass deleted the fix-node-versions branch October 24, 2022 15:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@aabmass@punya