Uh oh!
There was an error while loading. Please reload this page.
Fix using file instead of io.IOBase - #140
Conversation
googlebot
commented
Dec 6, 2018
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
martin2250
commented
Dec 6, 2018
I signed it! |
googlebot
commented
Dec 6, 2018
CLAs look good, thanks! |
fahhem
commented
Dec 6, 2018
This is not backwards-compatible with Python 2. Please check against |
martin2250
commented
Dec 6, 2018
Which method do you think is better in this case, using the tuple and try/except or checking |
fahhem
commented
Dec 6, 2018
I think |
martin2250
commented
Dec 8, 2018
Ok, the PR should be good now |
As mentioned in #126