Uh oh!
There was an error while loading. Please reload this page.
Fix RSA keyfile open mode (rb) for python3 (#141) - #142
Conversation
googlebot
commented
Dec 11, 2018
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Experiencing the same issue, I validated the fix on my side with Python RSA 4.0 and Python 3.6: I followed the steps to reproduce as mentioned in #141 :
|
joeleong
commented
Jan 4, 2019
I signed it! |
googlebot
commented
Jan 4, 2019
CLAs look good, thanks! |
greyltc
commented
Sep 30, 2019
What needs to be done to get this merged? The bug in master that this PR fixes seems to make the project useless under python 3. |
Proposed fix for #141
I only really tested it with the
m2cryptosigner, but I assumed it would be the same forsign_pythonrsa.py