Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Fix TCP connections on python 2 - #150

Open
embray wants to merge 1 commit into
google:masterfrom
embray:python2/tcp-port
Open

Fix TCP connections on python 2#150
embray wants to merge 1 commit into
google:masterfrom
embray:python2/tcp-port

Conversation

@embray

Copy link
Copy Markdown

On python 2 socket.create_connection requires the port to be an int.

I'm not overly concerned about Python 2 support. Indeed I'm mostly using Python 3. I just happened to hit on this while testing some other code on Python 2.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@embray

Copy link
Copy Markdown
Author

I signed it!

@coveralls

coveralls commented Mar 17, 2019

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 43.531% when pulling 4bcf757 on embray:python2/tcp-port into d9b94b2 on google:master.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@JeffLIrionJeffLIrion mentioned this pull request Sep 24, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@embray@googlebot@coveralls